improve: remove JSON Patch from PrimaryUpdateAndCacheUtils #2795
Closed
improve: remove JSON Patch from PrimaryUpdateAndCacheUtils #2795
Conversation
If no optimistic locking is used a list element removal might remove an not desired element if there was a concurrent element removal. Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
csviri
changed the title
Collaborator
Author
|
I think this is a gray area to discuss, we might say that this is the responsibility of the user to evaluate if JSON Patch is valid for his/her use case. |
metacosm
approved these changes
May 14, 2025
Collaborator
Author
|
@metacosm usage is documented here: https://javaoperatorsdk.io/docs/documentation/reconciler/#using-internal-cache Will do some improvements today, and will take a look on javadoc too |
Collaborator
Author
|
improved javadoc and namings is a followup PR: #2796 |
Collaborator
Author
|
Still a bit hesitating on this one, we might just point out the risk of JSON Patch. |
Collaborator
Author
|
at the end I think a better approach is just document the risk, will do it here: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.