Skip to content

refactor: avoid unneeded initializations in injection contexts #2950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
metacosm merged 2 commits into from
Sep 20, 2025
Merged

refactor: avoid unneeded initializations in injection contexts #2950

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b0d8146
refactor: avoid unneeded initializations in injection contexts
metacosm Sep 17, 2025
26e72bf
docs: added javadoc and tests
metacosm Sep 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 26 additions & 11 deletions operator-framework-core/src/main/java/io/javaoperatorsdk/operator/Operator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,17 +24,17 @@
public class Operator implements LifecycleAware {
private static final Logger log = LoggerFactory.getLogger(Operator.class);

private final ControllerManager controllerManager;
private final LeaderElectionManager leaderElectionManager;
private final ConfigurationService configurationService;
private ControllerManager controllerManager;
private LeaderElectionManager leaderElectionManager;
private ConfigurationService configurationService;
private volatile boolean started = false;

public Operator() {
this((KubernetesClient) null);
init(initConfigurationService(null, null), true);
}

Operator(KubernetesClient kubernetesClient) {
this(initConfigurationService(kubernetesClient, null));
init(initConfigurationService(kubernetesClient, null), false);
}

/**
Expand All @@ -46,12 +46,23 @@ public Operator() {
* operator
*/
public Operator(ConfigurationService configurationService) {
this.configurationService = configurationService;
init(configurationService, false);
}

private void init(ConfigurationService configurationService, boolean allowDeferredInit) {
if (configurationService == null) {
if (!allowDeferredInit) {
Copy link
Copy Markdown
Collaborator

@csviri csviri Sep 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a unit test for this?

Copy link
Copy Markdown
Collaborator Author

@metacosm metacosm Sep 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a test, though it's not great and additional documentation, along with a protected method for subclasses to set the configuration service after intialization, if needed.

throw new IllegalStateException(
"Deferred initialization of ConfigurationService is not allowed");
}
} else {
this.configurationService = configurationService;

final var executorServiceManager = configurationService.getExecutorServiceManager();
controllerManager = new ControllerManager(executorServiceManager);
final var executorServiceManager = configurationService.getExecutorServiceManager();
controllerManager = new ControllerManager(executorServiceManager);

leaderElectionManager = new LeaderElectionManager(controllerManager, configurationService);
leaderElectionManager = new LeaderElectionManager(controllerManager, configurationService);
}
}

/**
Expand All @@ -62,10 +73,14 @@ public Operator(ConfigurationService configurationService) {
* {@link ConfigurationService} values
*/
public Operator(Consumer<ConfigurationServiceOverrider> overrider) {
this(initConfigurationService(null, overrider));
init(initConfigurationService(null, overrider), false);
}

private static ConfigurationService initConfigurationService(
/**
* Overridable by subclasses to enable deferred configuration, useful to avoid unneeded processing
* in injection scenarios
*/
protected ConfigurationService initConfigurationService(
KubernetesClient client, Consumer<ConfigurationServiceOverrider> overrider) {
// initialize the client if the user didn't provide one
if (client == null) {
Expand Down