improve: simplified MicrometerMetricsV2 builder api#3220
Merged
csviri merged 1 commit intooperator-framework:nextfrom Mar 12, 2026
Merged
improve: simplified MicrometerMetricsV2 builder api#3220csviri merged 1 commit intooperator-framework:nextfrom
csviri merged 1 commit intooperator-framework:nextfrom
Conversation
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR simplifies the MicrometerMetricsV2 builder entrypoint by renaming the static factory method used to obtain a MicrometerMetricsV2Builder, and updates the sample operator to use the new API.
Changes:
- Renamed
MicrometerMetricsV2.newMicrometerMetricsV2Builder(MeterRegistry)toMicrometerMetricsV2.newBuilder(MeterRegistry). - Updated the metrics-processing sample operator to call the new builder factory method.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| sample-operators/metrics-processing/src/main/java/io/javaoperatorsdk/operator/sample/metrics/MetricsHandlingSampleOperator.java | Updates sample code to use the renamed builder factory method. |
| micrometer-support/src/main/java/io/javaoperatorsdk/operator/monitoring/micrometer/MicrometerMetricsV2.java | Renames the public static builder factory method for MicrometerMetricsV2. |
You can also share your feedback on Copilot code review. Take the survey.
...ort/src/main/java/io/javaoperatorsdk/operator/monitoring/micrometer/MicrometerMetricsV2.java
Show resolved
Hide resolved
metacosm
approved these changes
Mar 12, 2026
csviri
added a commit
that referenced
this pull request
Mar 13, 2026
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Attila Mészáros a_meszaros@apple.com