Skip to content

fix: adding missing tags for non k8s events #3256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
csviri merged 8 commits into from
Mar 27, 2026
Merged

fix: adding missing tags for non k8s events #3256

Changes from 3 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
c001f86
fix: adding missing tags for non k8s events
csviri Mar 26, 2026
f59d07b
wip
csviri Mar 26, 2026
39e58cc
wip
csviri Mar 26, 2026
258fc0c
wip
csviri Mar 27, 2026
5a44c3c
wip
csviri Mar 27, 2026
0685dd6
wip
csviri Mar 27, 2026
c3f8698
wip
csviri Mar 27, 2026
4ddc85a
wip
csviri Mar 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion .../src/main/java/io/javaoperatorsdk/operator/monitoring/micrometer/MicrometerMetricsV2.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,8 @@ public class MicrometerMetricsV2 implements Metrics {

public static final String RECONCILIATION_EXECUTION_DURATION =
RECONCILIATIONS + "execution.duration";
public static final String NO_NAMESPACE = "NO_NAMESPACE";
public static final String UNKNOWN_ACTION = "UNKNOWN";

private final MeterRegistry registry;
private final Map<String, AtomicInteger> gauges = new ConcurrentHashMap<>();
Expand Down Expand Up @@ -176,7 +178,11 @@ public void eventReceived(Event event, Map<String, Object> metadata) {
Tag.of(ACTION, resourceEvent.getAction().toString()));
} else {
incrementCounter(
EVENTS_RECEIVED, null, metadata, Tag.of(EVENT, event.getClass().getSimpleName()));
EVENTS_RECEIVED,
null,
metadata,
Tag.of(EVENT, event.getClass().getSimpleName()),
Tag.of(ACTION, UNKNOWN_ACTION));
}
}

Expand Down Expand Up @@ -246,6 +252,8 @@ private static void addControllerNameTag(String name, List<Tag> tags) {
private void addNamespaceTag(String namespace, List<Tag> tags) {
if (includeNamespaceTag && namespace != null && !namespace.isBlank()) {
addTag(NAMESPACE, namespace, tags);
} else {
addTag(NAMESPACE, NO_NAMESPACE, tags);
}
}

Expand Down
Loading