test: Verify migrated revision status is set correctly

Add explicit test assertions to verify that the BoxcutterStorageMigrator
sets the Succeeded=True status condition with the Migrated reason when
creating revisions from Helm releases.

This ensures the migration fix works correctly by:
- Verifying Status().Update() is called during migration
- Asserting the Succeeded condition is set to True
- Confirming the reason is ClusterExtensionRevisionReasonMigrated
- Validating the message and ObservedGeneration are correct

Also adds missing k8s.io/apimachinery/pkg/api/meta import to boxcutter.go
that was needed for the meta.SetStatusCondition call.

The test now captures the status update in a persistent statusWriterMock
instance, allowing verification of the status condition that prevents the
timing gap issue during OLM upgrades.

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>

Author: camilamacedo86

internal/operator-controller/applier/boxcutter.go

@@ -15,6 +15,7 @@ import (
 	"helm.sh/helm/v3/pkg/release"
 	"helm.sh/helm/v3/pkg/storage/driver"
 	apierrors "k8s.io/apimachinery/pkg/api/errors"
+	"k8s.io/apimachinery/pkg/api/meta"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	"k8s.io/apimachinery/pkg/apis/meta/v1/unstructured"
 	"k8s.io/apimachinery/pkg/runtime"

internal/operator-controller/applier/boxcutter_test.go

@@ -19,6 +19,7 @@ import (
 	corev1 "k8s.io/api/core/v1"
 	rbacv1 "k8s.io/api/rbac/v1"
 	apierrors "k8s.io/apimachinery/pkg/api/errors"
+	apimeta "k8s.io/apimachinery/pkg/api/meta"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	"k8s.io/apimachinery/pkg/apis/meta/v1/unstructured"
 	"k8s.io/apimachinery/pkg/runtime"
@@ -1251,6 +1252,21 @@ func TestBoxcutterStorageMigrator(t *testing.T) {
 		require.NoError(t, err)
 
 		client.AssertExpectations(t)
+
+		// Verify the migrated revision has Succeeded=True status with Migrated reason
+		statusWriter := client.Status().(*statusWriterMock)
+		require.True(t, statusWriter.updateCalled, "Status().Update() should be called during migration")
+		require.NotNil(t, statusWriter.updatedObj, "Updated object should not be nil")
+
+		rev, ok := statusWriter.updatedObj.(*ocv1.ClusterExtensionRevision)
+		require.True(t, ok, "Updated object should be a ClusterExtensionRevision")
+
+		succeededCond := apimeta.FindStatusCondition(rev.Status.Conditions, ocv1.ClusterExtensionRevisionTypeSucceeded)
+		require.NotNil(t, succeededCond, "Succeeded condition should be set")
+		assert.Equal(t, metav1.ConditionTrue, succeededCond.Status, "Succeeded condition should be True")
+		assert.Equal(t, ocv1.ClusterExtensionRevisionReasonMigrated, succeededCond.Reason, "Reason should be Migrated")
+		assert.Equal(t, "Migrated from Helm release", succeededCond.Message, "Message should indicate Helm migration")
+		assert.Equal(t, int64(1), succeededCond.ObservedGeneration, "ObservedGeneration should match revision generation")
 	})
 
 	t.Run("does not create revision when revisions exist", func(t *testing.T) {
@@ -1345,6 +1361,7 @@ func (m *mockBundleRevisionBuilder) GenerateRevisionFromHelmRelease(
 
 type clientMock struct {
 	mock.Mock
+	statusWriter *statusWriterMock
 }
 
 func (m *clientMock) List(ctx context.Context, list client.ObjectList, opts ...client.ListOption) error {
@@ -1363,15 +1380,22 @@ func (m *clientMock) Create(ctx context.Context, obj client.Object, opts ...clie
 }
 
 func (m *clientMock) Status() client.StatusWriter {
-	return &statusWriterMock{mock: &m.Mock}
+	if m.statusWriter == nil {
+		m.statusWriter = &statusWriterMock{mock: &m.Mock}
+	}
+	return m.statusWriter
 }
 
 type statusWriterMock struct {
-	mock *mock.Mock
+	mock         *mock.Mock
+	updatedObj   client.Object
+	updateCalled bool
 }
 
 func (s *statusWriterMock) Update(ctx context.Context, obj client.Object, opts ...client.SubResourceUpdateOption) error {
-	// Status updates are expected during migration - return success by default
+	// Capture the status update for test verification
+	s.updatedObj = obj
+	s.updateCalled = true
 	return nil
 }