Skip to content

Commit 6229df1

Browse files
committed
docs: add comment clarifying Blocked takes precedence over ProgressDeadlineExceeded
1 parent dffb3c3 commit 6229df1

1 file changed

Lines changed: 1 addition & 0 deletions

File tree

internal/operator-controller/controllers/clusterobjectset_controller.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -127,6 +127,7 @@ func (c *ClusterObjectSetReconciler) reconcile(ctx context.Context, cos *ocv1.Cl
127127
remaining, hasDeadline := durationUntilDeadline(c.Clock, cos)
128128
isDeadlineExceeded := hasDeadline && remaining <= 0
129129

130+
// Blocked takes precedence over ProgressDeadlineExceeded: it is more actionable for the user.
130131
if err := c.verifyReferencedSecretsImmutable(ctx, cos); err != nil {
131132
l.Error(err, "referenced Secret verification failed, blocking reconciliation")
132133
markAsNotProgressing(cos, ocv1.ClusterObjectSetReasonBlocked, err.Error())

0 commit comments

Comments
 (0)