(rukpak) extend bundle renderer to accept config opts

Introduce BundleConfig that contains InstallConfig and DeploymentConfig.

Author: anik120

internal/operator-controller/rukpak/convert/helm.go

@@ -7,6 +7,9 @@ import (
 
 	"helm.sh/helm/v3/pkg/chart"
 
+	"github.com/operator-framework/api/pkg/operators/v1alpha1"
+
+	"github.com/operator-framework/operator-controller/internal/operator-controller/rukpak/bundle"
 	"github.com/operator-framework/operator-controller/internal/operator-controller/rukpak/bundle/source"
 	"github.com/operator-framework/operator-controller/internal/operator-controller/rukpak/render"
 )
@@ -18,11 +21,27 @@ type BundleToHelmChartConverter struct {
 }
 
 func (r *BundleToHelmChartConverter) ToHelmChart(bundle source.BundleSource, installNamespace string, watchNamespace string) (*chart.Chart, error) {
+	config := make(map[string]string)
+
+	if watchNamespace != "" {
+		config["watchNamespace"] = watchNamespace
+	}
+
 	rv1, err := bundle.GetBundle()
 	if err != nil {
 		return nil, err
 	}
 
+	var opts []render.Option
+
+	opts = append(opts, render.WithCertificateProvider(r.CertificateProvider))
+
+	targetNsOpt, err := r.buildTargetNamespacesOption(config, &rv1, installNamespace)
+	if err != nil {
+		return nil, err
+	}
+	opts = append(opts, targetNsOpt)
+
 	if len(rv1.CSV.Spec.APIServiceDefinitions.Owned) > 0 {
 		return nil, fmt.Errorf("unsupported bundle: apiServiceDefintions are not supported")
 	}
@@ -39,11 +58,7 @@ func (r *BundleToHelmChartConverter) ToHelmChart(bundle source.BundleSource, ins
 		return nil, fmt.Errorf("unsupported bundle: webhookDefinitions are not supported")
 	}
 
-	objs, err := r.BundleRenderer.Render(
-		rv1, installNamespace,
-		render.WithTargetNamespaces(watchNamespace),
-		render.WithCertificateProvider(r.CertificateProvider),
-	)
+	objs, err := r.BundleRenderer.Render(rv1, installNamespace, opts...)
 
 	if err != nil {
 		return nil, fmt.Errorf("error rendering bundle: %w", err)
@@ -77,3 +92,55 @@ func (r *BundleToHelmChartConverter) ToHelmChart(bundle source.BundleSource, ins
 
 	return chrt, nil
 }
+
+// buildTargetNamespacesOption creates the target namespaces option based on configuration
+func (r *BundleToHelmChartConverter) buildTargetNamespacesOption(config map[string]string, rv1 *bundle.RegistryV1, installNamespace string) (render.Option, error) {
+	if watchNs, exists := config["watchNamespace"]; exists {
+		if watchNs == "" {
+			return render.WithTargetNamespaces(""), nil
+		}
+		return render.WithTargetNamespaces(watchNs), nil
+	}
+
+	// No watchNamespace configured - derive default
+	defaultWatchNs, err := r.deriveDefaultWatchNamespace(rv1, installNamespace)
+	if err != nil {
+		return nil, fmt.Errorf("error deriving default watch namespace: %w", err)
+	}
+
+	if defaultWatchNs == "" {
+		return render.WithTargetNamespaces(""), nil
+	}
+	return render.WithTargetNamespaces(defaultWatchNs), nil
+}
+
+// deriveDefaultWatchNamespace determines the default watch namespace based on bundle's supported install modes
+func (r *BundleToHelmChartConverter) deriveDefaultWatchNamespace(rv1 *bundle.RegistryV1, installNamespace string) (string, error) {
+	supportedModes := make(map[v1alpha1.InstallModeType]bool)
+	for _, installMode := range rv1.CSV.Spec.InstallModes {
+		if installMode.Supported {
+			supportedModes[installMode.Type] = true
+		}
+	}
+
+	// Priority order for defaults:
+	// 1. If supports AllNamespaces -> "" (AllNamespaces)
+	// 2. If supports OwnNamespace -> installNamespace (OwnNamespace)
+	// 3. If only supports SingleNamespace or MultiNamespace -> error (watchNamespace needs to be explicitly set, cannot derive default)
+	// 4. No supported modes -> error
+
+	if supportedModes[v1alpha1.InstallModeTypeAllNamespaces] {
+		return "", nil // Empty string means AllNamespaces
+	}
+	if supportedModes[v1alpha1.InstallModeTypeOwnNamespace] {
+		return installNamespace, nil // OwnNamespace
+	}
+	if supportedModes[v1alpha1.InstallModeTypeSingleNamespace] {
+		return "", fmt.Errorf("config parameter watchNamespace required: bundle only supports SingleNamespace install mode")
+	}
+	if supportedModes[v1alpha1.InstallModeTypeMultiNamespace] {
+		return "", fmt.Errorf("bundle only supports MultiNamespace install mode")
+	}
+
+	return "", fmt.Errorf("bundle has no supported install modes")
+}