🐛 e2e: don't pre-populate clusterObjectSetName in scenario context

joelanford · claude · joelanford · commit fb9f3e636091 · 2026-04-18T07:01:28.000-04:00
The clusterObjectSetName was unconditionally set to a pre-generated value
for every scenario in CreateScenarioContext, causing cleanup to attempt
deleting a clusterobjectset resource even when the CRD doesn't exist
(non-experimental suites). Now it starts empty and only gets set when a
ClusterObjectSet is actually applied during the scenario.

Co-Authored-By: Claude Opus 4.6 (1M context) &lt;noreply@anthropic.com&gt;
diff --git a/test/e2e/steps/hooks.go b/test/e2e/steps/hooks.go
@@ -166,7 +166,6 @@ func CreateScenarioContext(ctx context.Context, sc *godog.Scenario) (context.Con
 		id:                   sc.Id,
 		namespace:            fmt.Sprintf("ns-%s", sc.Id),
 		clusterExtensionName: fmt.Sprintf("ce-%s", sc.Id),
-		clusterObjectSetName: fmt.Sprintf("cos-%s", sc.Id),
 		leaderPods:           make(map[string]string),
 	}
 	return context.WithValue(ctx, scenarioContextKey, scCtx), nil

Original file line number	Diff line number	Diff line change
`@@ -166,7 +166,6 @@ func CreateScenarioContext(ctx context.Context, sc *godog.Scenario) (context.Con`
`166`	`166`	`id: sc.Id,`
`167`	`167`	`namespace: fmt.Sprintf("ns-%s", sc.Id),`
`168`	`168`	`clusterExtensionName: fmt.Sprintf("ce-%s", sc.Id),`
`169`		`- clusterObjectSetName: fmt.Sprintf("cos-%s", sc.Id),`
`170`	`169`	`leaderPods: make(map[string]string),`
`171`	`170`	`}`
`172`	`171`	`return context.WithValue(ctx, scenarioContextKey, scCtx), nil`