✨ Add Network Policy to e2e test bundles#2078
✨ Add Network Policy to e2e test bundles#2078openshift-merge-bot[bot] merged 1 commit intooperator-framework:mainfrom
Conversation
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2078 +/- ##
==========================================
+ Coverage 73.34% 73.37% +0.03%
==========================================
Files 77 77
Lines 7056 7076 +20
==========================================
+ Hits 5175 5192 +17
- Misses 1541 1543 +2
- Partials 340 341 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
/approve |
Adds a Netwok Policy to the end-to-end test bundles and adds a check to the tests that the Network Policy resources are created. Signed-off-by: Tayler Geiger <tayler@redhat.com>
openshift-ci
Bot
added
lgtm
| - list | ||
| - create | ||
| - update | ||
| - delete |
There was a problem hiding this comment.
Sorry, now I see that we have the NP in both sample versions
Can we have it in one version only, so we ensure that it works with both cases? (with and without NP)
There was a problem hiding this comment.
Did you not mean to approve it? It already merged from your review. Also, not having the NP in one version isn't going to be any different, we always want to be able to support installing NPs so we always want the e2e to try to install one so the CI fails if it can't. There's no value-add from running the same test without an NP.
There was a problem hiding this comment.
It was a nit idea, I think we may could cover both scenarios
But it is all fine. I think it is OK as it is no worry.
There was a problem hiding this comment.
Btw, thank you a lot for taking care of that !!!
camilamacedo86
dismissed
their stale review
I just noticed one thing. Just a small question before moving forward.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: oceanc80 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
openshift-ci
Bot
removed
the
approved
openshift-merge-bot
Bot
merged commit bc0f609
into
operator-framework:main
4 participants
Adds a Netwok Policy to the end-to-end test bundles and adds a check to the tests that the Network Policy resources are created. Closes OPRUN-3967
Description
Reviewer Checklist