🌱 Add inline bundle config admission unit tests#2279
Conversation
Signed-off-by: Per G. da Silva <pegoncal@redhat.com>
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2279 +/- ##
==========================================
+ Coverage 70.28% 70.31% +0.03%
==========================================
Files 88 88
Lines 8762 8762
==========================================
+ Hits 6158 6161 +3
+ Misses 2190 2188 -2
+ Partials 414 413 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86, pedjak, thetechnick The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
57345c8
into
operator-framework:main
Description
Adds a couple of unit tests to exercise the .spec.config.inline schema validation (specifically as it pertains to expecting whole json objects).
Note: we should also be able to inject valid yaml. However, this was not being accepted by the client in the test - it expected valid json. I'm not sure what we can do to add this test at this level =S
Reviewer Checklist