🐛 Fix serviceAccountName placement in test bundles#2611
Conversation
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull request overview
Fixes malformed test bundle CSV manifests by moving serviceAccountName to the correct location in the pod template spec.
Changes:
- Relocates
serviceAccountName: simple-bundle-managerintospec.install.spec.deployments[].spec.template.specacross multiple test bundle CSVs. - Removes incorrectly placed
serviceAccountNameentries that were nested under container/probe blocks (invalid for a PodSpec).
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| testdata/images/bundles/test-operator/v1.2.0/manifests/testoperator.clusterserviceversion.yaml | Moves serviceAccountName into the deployment pod template spec and removes the invalid nested occurrence. |
| testdata/images/bundles/test-operator/v1.0.3/manifests/testoperator.clusterserviceversion.yaml | Same correction for the v1.0.3 test bundle CSV. |
| testdata/images/bundles/test-operator/v1.0.2/manifests/testoperator.clusterserviceversion.yaml | Same correction for the v1.0.2 test bundle CSV. |
| testdata/images/bundles/test-operator/v1.0.0/manifests/testoperator.clusterserviceversion.yaml | Same correction for the v1.0.0 test bundle CSV. |
| testdata/images/bundles/single-namespace-operator/v1.0.0/manifests/singlenamespaceoperator.clusterserviceversion.yaml | Same correction for the single-namespace operator test bundle CSV. |
| testdata/images/bundles/own-namespace-operator/v1.0.0/manifests/ownnamespaceoperator.clusterserviceversion.yaml | Same correction for the own-namespace operator test bundle CSV. |
| testdata/images/bundles/large-crd-operator/v1.0.0/manifests/largecrdoperator.clusterserviceversion.yaml | Same correction for the large CRD operator test bundle CSV. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2611 +/- ##
===========================================
+ Coverage 53.50% 68.92% +15.41%
===========================================
Files 139 139
Lines 9872 9872
===========================================
+ Hits 5282 6804 +1522
+ Misses 4210 2554 -1656
- Partials 380 514 +134
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pedjak The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
435e9c5
into
operator-framework:main
The SA was in the wrong position (invalid spec position) which may caused to be ignored.
It is fixed now.