Skip to content

🐛 Fix serviceAccountName placement in test bundles#2611

Merged
openshift-merge-bot[bot] merged 1 commit intooperator-framework:mainfrom
camilamacedo86:fix-sa-testdata
Mar 31, 2026
Merged

🐛 Fix serviceAccountName placement in test bundles#2611
openshift-merge-bot[bot] merged 1 commit intooperator-framework:mainfrom
camilamacedo86:fix-sa-testdata

Conversation

@camilamacedo86
Copy link
Copy Markdown
Contributor

@camilamacedo86 camilamacedo86 commented Mar 31, 2026

The SA was in the wrong position (invalid spec position) which may caused to be ignored.
It is fixed now.

Copilot AI review requested due to automatic review settings March 31, 2026 06:07
@openshift-ci openshift-ci Bot requested review from dtfranz and grokspawn March 31, 2026 06:07
@netlify
Copy link
Copy Markdown

netlify Bot commented Mar 31, 2026

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit e40c2e4
🔍 Latest deploy log https://app.netlify.com/projects/olmv1/deploys/69cb64aad47bf20008d48a38
😎 Deploy Preview https://deploy-preview-2611--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes malformed test bundle CSV manifests by moving serviceAccountName to the correct location in the pod template spec.

Changes:

  • Relocates serviceAccountName: simple-bundle-manager into spec.install.spec.deployments[].spec.template.spec across multiple test bundle CSVs.
  • Removes incorrectly placed serviceAccountName entries that were nested under container/probe blocks (invalid for a PodSpec).

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
File Description
testdata/images/bundles/test-operator/v1.2.0/manifests/testoperator.clusterserviceversion.yaml Moves serviceAccountName into the deployment pod template spec and removes the invalid nested occurrence.
testdata/images/bundles/test-operator/v1.0.3/manifests/testoperator.clusterserviceversion.yaml Same correction for the v1.0.3 test bundle CSV.
testdata/images/bundles/test-operator/v1.0.2/manifests/testoperator.clusterserviceversion.yaml Same correction for the v1.0.2 test bundle CSV.
testdata/images/bundles/test-operator/v1.0.0/manifests/testoperator.clusterserviceversion.yaml Same correction for the v1.0.0 test bundle CSV.
testdata/images/bundles/single-namespace-operator/v1.0.0/manifests/singlenamespaceoperator.clusterserviceversion.yaml Same correction for the single-namespace operator test bundle CSV.
testdata/images/bundles/own-namespace-operator/v1.0.0/manifests/ownnamespaceoperator.clusterserviceversion.yaml Same correction for the own-namespace operator test bundle CSV.
testdata/images/bundles/large-crd-operator/v1.0.0/manifests/largecrdoperator.clusterserviceversion.yaml Same correction for the large CRD operator test bundle CSV.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 31, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.92%. Comparing base (43351b2) to head (e40c2e4).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2611       +/-   ##
===========================================
+ Coverage   53.50%   68.92%   +15.41%     
===========================================
  Files         139      139               
  Lines        9872     9872               
===========================================
+ Hits         5282     6804     +1522     
+ Misses       4210     2554     -1656     
- Partials      380      514      +134     
Flag Coverage Δ
e2e 37.73% <ø> (?)
experimental-e2e 52.64% <ø> (?)
unit 53.50% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

@pedjak pedjak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Mar 31, 2026
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Mar 31, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pedjak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 31, 2026
@openshift-merge-bot openshift-merge-bot Bot merged commit 435e9c5 into operator-framework:main Mar 31, 2026
31 checks passed
@camilamacedo86 camilamacedo86 deleted the fix-sa-testdata branch March 31, 2026 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants