BREAKING CHANGE: drop all sqlite support

[grokspawn]

Description of the change:
A view of how opm would look if we drop all SQLite support (which has been deprecated for 4+ years).
An earlier iteration of this PR also dropped the model intermetiate package, but findings of current bugs as well as the added complexity suggest we'd be better off doing a separate PR for it.

Motivation for the change:

Reviewer Checklist

• Implementation matches the proposed design, or proposal is updated to match implementation
• Sufficient unit test coverage
• Sufficient end-to-end test coverage
• Docs updated or added to /docs
• Commit messages sensible and descriptive

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign camilamacedo86 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[Copilot]

Pull request overview

This PR removes the long-deprecated SQLite-based catalog/index path from operator-registry and drops the (internal/alpha) channel priority property support, leaving the file-based catalog (FBC / declarative config) path as the supported workflow.

Changes:

• Remove SQLite implementation code, migrations, testdata, and sqlite-backed CLI surfaces (opm index, opm registry, standalone servers, sqlite migration command).
• Remove channel priority property construction in the alpha property layer.
• Adjust build configuration/dependencies to reflect the removal (tags/CGO changes, module dependency cleanup).

Reviewed changes

Copilot reviewed 115 out of 163 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
test/e2e/opm_test.go	Removes sqlite/indexer imports (but file still contains sqlite/indexer usages; currently breaks compilation).
pkg/sqlite/testdata/test_db_migrations/valid/200412250000_fake_migration.up.sql	Removes sqlite migration testdata.
pkg/sqlite/testdata/test_db_migrations/valid/200412250000_fake_migration.down.sql	Removes sqlite migration testdata.
pkg/sqlite/testdata/test_db_migrations/valid/200112250000_fake_migration.up.sql	Removes sqlite migration testdata.
pkg/sqlite/testdata/test_db_migrations/valid/200112250000_fake_migration.down.sql	Removes sqlite migration testdata.
pkg/sqlite/testdata/test_db_migrations/invalid/randomscript.sql	Removes sqlite migration testdata.
pkg/sqlite/testdata/strandedbundles/prometheus.0.22.2/metadata/dependencies.yaml	Removes sqlite stranded-bundle test fixture.
pkg/sqlite/testdata/strandedbundles/prometheus.0.22.2/metadata/annotations.yaml	Removes sqlite stranded-bundle test fixture.
pkg/sqlite/testdata/strandedbundles/prometheus.0.22.2/manifests/prometheusrule.crd.yaml	Removes sqlite stranded-bundle test fixture.
pkg/sqlite/testdata/strandedbundles/prometheus.0.15.0/metadata/annotations.yaml	Removes sqlite stranded-bundle test fixture.
pkg/sqlite/testdata/strandedbundles/prometheus.0.15.0/manifests/prometheusrule.crd.yaml	Removes sqlite stranded-bundle test fixture.
pkg/sqlite/testdata/strandedbundles/prometheus.0.14.0/metadata/annotations.yaml	Removes sqlite stranded-bundle test fixture.
pkg/sqlite/testdata/strandedbundles/prometheus.0.14.0/manifests/prometheusrule.crd.yaml	Removes sqlite stranded-bundle test fixture.
pkg/sqlite/testdata/loader_data/prometheus/prometheus.package.yaml	Removes sqlite loader test fixture.
pkg/sqlite/testdata/loader_data/prometheus/0.22.2/servicemonitor.crd.yaml	Removes sqlite loader test fixture.
pkg/sqlite/testdata/loader_data/prometheus/0.22.2/prometheusrule.crd.yaml	Removes sqlite loader test fixture.
pkg/sqlite/testdata/loader_data/prometheus/0.15.0/servicemonitor.crd.yaml	Removes sqlite loader test fixture.
pkg/sqlite/testdata/loader_data/prometheus/0.15.0/prometheusrule.crd.yaml	Removes sqlite loader test fixture.
pkg/sqlite/testdata/loader_data/prometheus/0.14.0/prometheusrule.crd.yaml	Removes sqlite loader test fixture.
pkg/sqlite/testdata/loader_data/etcd/etcd.package.yaml	Removes sqlite loader test fixture.
pkg/sqlite/testdata/loader_data/etcd/0.9.2/etcdrestore.crd.yaml	Removes sqlite loader test fixture.
pkg/sqlite/testdata/loader_data/etcd/0.9.2/etcdcluster.crd.yaml	Removes sqlite loader test fixture.
pkg/sqlite/testdata/loader_data/etcd/0.9.2/etcdbackup.crd.yaml	Removes sqlite loader test fixture.
pkg/sqlite/testdata/loader_data/etcd/0.6.1/etcdcluster.crd.yaml	Removes sqlite loader test fixture.
pkg/sqlite/testdata/incorrectbundle/3scale-community-operator/3scale-community-operator.package.yaml	Removes sqlite incorrect-bundle test fixture.
pkg/sqlite/testdata/incorrectbundle/3scale-community-operator/0.3.0/tenants.capabilities.3scale.net.crd.yaml	Removes sqlite incorrect-bundle test fixture.
pkg/sqlite/testdata/incorrectbundle/3scale-community-operator/0.3.0/plans.capabilities.3scale.net.crd.yaml	Removes sqlite incorrect-bundle test fixture.
pkg/sqlite/testdata/incorrectbundle/3scale-community-operator/0.3.0/metrics.capabilities.3scale.net.crd.yaml	Removes sqlite incorrect-bundle test fixture.
pkg/sqlite/testdata/incorrectbundle/3scale-community-operator/0.3.0/mappingrules.capabilities.3scale.net.crd.yaml	Removes sqlite incorrect-bundle test fixture.
pkg/sqlite/testdata/incorrectbundle/3scale-community-operator/0.3.0/limits.capabilities.3scale.net.crd.yaml	Removes sqlite incorrect-bundle test fixture.
pkg/sqlite/testdata/incorrectbundle/3scale-community-operator/0.3.0/bindings.capabilities.3scale.net.crd.yaml	Removes sqlite incorrect-bundle test fixture.
pkg/sqlite/testdata/incorrectbundle/3scale-community-operator/0.3.0/apimanagers.apps.3scale.net.crd.yaml	Removes sqlite incorrect-bundle test fixture.
pkg/sqlite/testdata/.gitignore	Removes sqlite testdata ignore rules.
pkg/sqlite/stranded.go	Removes sqlite stranded bundle remover implementation.
pkg/sqlite/stranded_test.go	Removes sqlite stranded bundle remover tests.
pkg/sqlite/sqlitefakes/fake_rowscanner.go	Removes generated fakes tied to sqlite interfaces.
pkg/sqlite/sqlitefakes/fake_querier.go	Removes generated fakes tied to sqlite interfaces.
pkg/sqlite/remove.go	Removes sqlite package removal implementation.
pkg/sqlite/remove_test.go	Removes sqlite package removal tests.
pkg/sqlite/migrator.go	Removes sqlite migrator implementation.
pkg/sqlite/migrations/migrations.go	Removes sqlite migrations registry/types.
pkg/sqlite/migrations/013_rm_truncated_deprecations.go	Removes sqlite migration.
pkg/sqlite/migrations/013_rm_truncated_deprecations_test.go	Removes sqlite migration test.
pkg/sqlite/migrations/012_deprecated.go	Removes sqlite migration.
pkg/sqlite/migrations/012_deprecated_test.go	Removes sqlite migration test.
pkg/sqlite/migrations/011_susbtitutes_for.go	Removes sqlite migration.
pkg/sqlite/migrations/010_set_bundlepath_pkg_property.go	Removes sqlite migration.
pkg/sqlite/migrations/009_properties.go	Removes sqlite migration.
pkg/sqlite/migrations/008_dependencies.go	Removes sqlite migration.
pkg/sqlite/migrations/007_replaces_skips.go	Removes sqlite migration.
pkg/sqlite/migrations/005_version_skiprange.go	Removes sqlite migration.
pkg/sqlite/migrations/003_required_apis.go	Removes sqlite migration.
pkg/sqlite/migrations/002_bundle_path.go	Removes sqlite migration.
pkg/sqlite/migrations/002_bundle_path_test.go	Removes sqlite migration test.
pkg/sqlite/migrations/001_related_images.go	Removes sqlite migration.
pkg/sqlite/migrations/000_init.go	Removes sqlite schema initialization migration.
pkg/sqlite/loadprocs.go	Removes sqlite loader helper procedures.
pkg/sqlite/graphloader.go	Removes sqlite graph loader implementation.
pkg/sqlite/graphloader_test.go	Removes sqlite graph loader tests.
pkg/sqlite/directory.go	Removes sqlite directory loader implementation.
pkg/sqlite/deprecationmessage.go	Removes sqlite deprecation message helper.
pkg/sqlite/deprecate.go	Removes sqlite deprecate/truncate logic.
pkg/sqlite/db.go	Removes sqlite DB open helpers and driver import.
pkg/sqlite/db_options.go	Removes sqlite DB options.
pkg/sqlite/conversion.go	Removes sqlite->model conversion path.
pkg/sqlite/conversion_test.go	Removes sqlite conversion tests.
pkg/sqlite/configmap.go	Removes sqlite configmap loader implementation.
pkg/mirror/options.go	Removes mirror options (tied to sqlite DB extraction path).
pkg/mirror/mirror.go	Removes index image mirroring implementation (sqlite DB driven).
pkg/mirror/mirror_test.go	Removes mirror tests.
pkg/lib/registry/registryfakes/fake_registry_deleter.go	Removes generated fakes for sqlite registry updater flow.
pkg/lib/registry/registryfakes/fake_registry_adder.go	Removes generated fakes for sqlite registry updater flow.
pkg/lib/registry/interfaces.go	Removes registry updater interfaces used by sqlite registry commands.
pkg/lib/indexer/testdata/package.yaml	Removes indexer testdata.
pkg/lib/indexer/interfaces.go	Removes indexer interfaces (sqlite-based index command plumbing).
pkg/lib/indexer/indexerfakes/fake_index_exporter.go	Removes generated fakes for indexer.
pkg/lib/indexer/indexerfakes/fake_index_deleter.go	Removes generated fakes for indexer.
pkg/lib/indexer/indexerfakes/fake_index_adder.go	Removes generated fakes for indexer.
pkg/lib/indexer/indexer_test.go	Removes indexer tests.
Makefile	Drops sqlite-related build tag; changes cross-build to CGO disabled.
go.mod	Removes direct sqlite-related deps, but still includes go-sqlite3 indirectly (may need cleanup).
cmd/registry-server/main.go	Removes deprecated standalone sqlite registry server binary.
cmd/opm/root/cmd.go	Removes opm index, opm registry, and opm migrate from root command.
cmd/opm/render/cmd.go	Removes sqlite from opm render help/behavior.
cmd/opm/registry/serve.go	Removes sqlite-backed opm registry serve.
cmd/opm/registry/rm.go	Removes sqlite-backed opm registry rm.
cmd/opm/registry/prunestranded.go	Removes sqlite-backed opm registry prune-stranded.
cmd/opm/registry/prune.go	Removes sqlite-backed opm registry prune.
cmd/opm/registry/mirror.go	Removes unused mirror command (sqlite-based).
cmd/opm/registry/deprecatetruncate.go	Removes sqlite-backed deprecate/truncate command.
cmd/opm/registry/cmd.go	Removes opm registry command group.
cmd/opm/registry/add.go	Removes sqlite-backed opm registry add.
cmd/opm/migrate/cmd.go	Removes sqlite->FBC migration command.
cmd/opm/index/prunestranded.go	Removes sqlite-backed opm index prune-stranded.
cmd/opm/index/prune.go	Removes sqlite-backed opm index prune.
cmd/opm/index/export.go	Removes sqlite-backed opm index export.
cmd/opm/index/deprecatetruncate.go	Removes sqlite-backed opm index deprecatetruncate.
cmd/opm/index/delete.go	Removes sqlite-backed opm index rm.
cmd/opm/index/cmd.go	Removes opm index command group.
cmd/opm/alpha/render-graph/cmd.go	Removes sqlite refs from alpha render-graph allowed ref set.
cmd/initializer/main.go	Removes deprecated initializer binary (manifests -> sqlite DB).
cmd/configmap-server/main.go	Removes configmap-server (configmap -> sqlite DB -> gRPC).
alpha/property/property.go	Drops channel priority property fields/builders.
alpha/action/render.go	Removes sqlite rendering support; now only supports declcfg images/dirs and bundles.
alpha/action/migrate.go	Disallows migrating sqlite refs (only declcfg image/dir).
alpha/action/migrate_test.go	Skips sqlite migration tests.
alpha/action/list.go	Disallows listing via sqlite refs (only declcfg image/dir).

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[codecov]

Codecov Report

❌ Patch coverage is 60.00000% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.55%. Comparing base (1a9dadf) to head (56eedcd).

Files with missing lines	Patch %	Lines
alpha/action/render.go	57.57%	13 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1986      +/-   ##
==========================================
+ Coverage   58.83%   59.55%   +0.72%     
==========================================
  Files         141       99      -42     
  Lines       13454     8157    -5297     
==========================================
- Hits         7915     4858    -3057     
+ Misses       4326     2724    -1602     
+ Partials     1213      575     -638     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[Copilot]

Pull request overview

Copilot reviewed 111 out of 170 changed files in this pull request and generated 3 comments.

[Copilot]

Copilot wasn't able to review this pull request because it exceeds the maximum number of lines (20,000). Try reducing the number of changed lines and requesting a review from Copilot again.

[Copilot]

Copilot wasn't able to review this pull request because it exceeds the maximum number of lines (20,000). Try reducing the number of changed lines and requesting a review from Copilot again.

[Copilot]

Copilot wasn't able to review this pull request because it exceeds the maximum number of lines (20,000). Try reducing the number of changed lines and requesting a review from Copilot again.

[Copilot]

Pull request overview

Copilot reviewed 108 out of 172 changed files in this pull request and generated 2 comments.

Comments suppressed due to low confidence (1)

README.md:103

• This section still refers to an "index" even though the preceding steps now describe building and serving a file-based catalog (FBC) image. Updating the heading/text helps avoid confusion for users now that SQLite/index workflows are removed.

# Using the index with Operator Lifecycle Manager

To add an index packaged with `operator-registry` to your cluster for use with [Operator Lifecycle Manager](https://github.com/operator-framework/operator-lifecycle-manager) (OLM) create a `CatalogSource` referencing the image you created and pushed above:

[grokspawn]

We may be able to drastically simplify our github release workflows now that the CGO dependency is no more!

Totally do-able in a follow-up, but don't want that to be overlooked!

Agreed. There are a few things we can iterate on after this lands.

[rashmigottipati]

changes look good to me overall, will wait for others to review as well

[Copilot]

Pull request overview

Copilot reviewed 108 out of 172 changed files in this pull request and generated 2 comments.

[Copilot]

Pull request overview

Copilot reviewed 108 out of 172 changed files in this pull request and generated 1 comment.

[Copilot]

Pull request overview

Copilot reviewed 108 out of 172 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

Makefile:70

• The static target still hardcodes the SQLite-specific build tag json1. With SQLite support removed and TAGS no longer including json1, this is misleading at best and can also lead to unexpected build-tag behavior for make static (which is used by upstream-builder.Dockerfile). Drop the hardcoded -tags "json1" and rely on -tags=$(TAGS) instead.

	GOOS=windows CGO_ENABLED=0 $(GO) build $(opm_version_flags) -tags=$(TAGS) -o "bin/windows-amd64-opm" -buildmode=exe ./cmd/opm
endif

.PHONY: static
static: extra_flags=-ldflags '-w -extldflags "-static"' -tags "json1"

[grokspawn]

@perdasilva I resolved all your comments above. It would be good if your LLM reviewer agent could classify the bugs by severity, and would also be a bit more relaxed for test-only versus product classification. For e.g., the catalog_built_test findings are really relevant for devs only, adding new testdata or scenarios.

[grokspawn]

IMHO, #2034 should be resolved (merged or responded-to with rationale to delay until re-versioning) before this merges.
/hold until some terminal state is reached on #2034

[grokspawn]

/hold cancel
#2034 cannot be merged until we have access to go builder images supporting the required version.

[Copilot]

Pull request overview

Copilot reviewed 109 out of 173 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (1)

cmd/opm/root/cmd.go:46

• This removes the opm registry / opm index command families from the CLI, but repo tooling still invokes them. For example, make sanity-check still runs ./bin/opm registry serve and mounts pkg/lib/indexer/testdata/bundles.db, which will fail with this new command surface.

Update the sanity-check (and any other scripts/docs) to use the remaining FBC workflow, e.g. mount fbc-dir/file-based-catalog and run opm validate /database or opm serve /database --cache-dir /tmp/cache --cache-only so the target continues to work after SQLite support is dropped.

	cmd.AddCommand(alpha.NewCmd(showAlphaHelp), initcmd.NewCmd(), migrate.NewCmd(), serve.NewCmd(), render.NewCmd(showAlphaHelp), validate.NewCmd(), generate.NewCmd())
	version.AddCommand(cmd)