Skip to content

Commit 09cb38a

Browse files
registry-server: save grace period when terminating
Make registry-server run with pid 1, after initialization so when the container is stopped, the process is gracefully terminated. Signed-off-by: Alejandro Visiedo <learning.little.engineer.2025.1@gmail.com>
1 parent 8f77948 commit 09cb38a

2 files changed

Lines changed: 2 additions & 2 deletions

File tree

internal/olm/operator/registry/configmap/deployment.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,7 @@ func withContainerVolumeMounts(volName string, paths ...string) func(*appsv1.Dep
106106
func getDBContainerCmd(dbPath, logPath string) string {
107107
initCmd := fmt.Sprintf("/bin/initializer -o %s -m %s", dbPath, containerManifestsDir)
108108
srvCmd := fmt.Sprintf("/bin/registry-server -d %s -t %s", dbPath, logPath)
109-
return fmt.Sprintf("%s && %s", initCmd, srvCmd)
109+
return fmt.Sprintf("%s && exec %s", initCmd, srvCmd)
110110
}
111111

112112
// withRegistryGRPCContainer returns a function that appends a container

internal/olm/operator/registry/configmap/deployment_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -160,7 +160,7 @@ var _ = Describe("Deployment", func() {
160160
initCmd := "/bin/initializer -o /path/to/database.db -m /registry/manifests"
161161
srvCmd := "/bin/registry-server -d /path/to/database.db -t /var/log/temp.log"
162162

163-
Expect(getDBContainerCmd("/path/to/database.db", "/var/log/temp.log")).Should(Equal(fmt.Sprintf("%s && %s", initCmd, srvCmd)))
163+
Expect(getDBContainerCmd("/path/to/database.db", "/var/log/temp.log")).Should(Equal(fmt.Sprintf("%s && exec %s", initCmd, srvCmd)))
164164
})
165165
})
166166

0 commit comments

Comments
 (0)