Prefer strings.SplitSeq over strings.Split where possible

SplitSeq returns an iterator over the substrings rather than
constructing and returning a slice, which works well in cases where
we are just iterating over the result anyways.

Signed-off-by: Caleb Xu <caxu@redhat.com>

Author: caxu-rh

internal/bindata/olm/manifests.go

@@ -38,8 +38,8 @@ func (i *InstallMode) Set(str string) error {
 	split := strings.SplitN(str, "=", 2)
 	i.InstallModeType = v1alpha1.InstallModeType(split[0])
 	if len(split) == 2 {
-		namespaces := strings.Split(split[1], ",")
-		for _, ns := range namespaces {
+		namespaces := strings.SplitSeq(split[1], ",")
+		for ns := range namespaces {
 			i.TargetNamespaces = append(i.TargetNamespaces, strings.TrimSpace(ns))
 		}
 		sort.Strings(i.TargetNamespaces)

internal/olm/operator/install_mode.go

@@ -106,7 +106,7 @@ func readArray(reader *bufio.Reader) []string {
 	arr := make([]string, 0)
 	text := readLine(reader)
 
-	for _, words := range strings.Split(text, ",") {
+	for words := range strings.SplitSeq(text, ",") {
 		arr = append(arr, strings.TrimSpace(words))
 	}
 	return arr