registry_pod: Avoid grace period delay

The shell script does not propagate the SIGTERM signal that is sent to
the pod when it is terminated; to avoid this, we run the last command to
substitute the shell process, so that the pod stop immediately instead of
waiting the 30 default seconds of the grace period when an user uninstall
the operator by using 'operator-sdk cleanup ...' command.

Signed-off-by: Alejandro Visiedo <learning.little.engineer.2025.1@gmail.com>

Author: little-engineer-2025

internal/olm/operator/registry/index/registry_pod.go

@@ -377,7 +377,7 @@ const cmdTemplate = `[[ -f {{ .DBPath }} ]] && cp {{ .DBPath }} /tmp/tmp.db; \
 {{- range $i, $item := .BundleItems }}
 opm registry add -d /tmp/tmp.db -b {{ $item.ImageTag }} --mode={{ $item.AddMode }}{{ if $.CASecretName }} --ca-file=/certs/cert.pem{{ end }} --skip-tls-verify={{ $.SkipTLSVerify }} --use-http={{ $.UseHTTP }} && \
 {{- end }}
-opm registry serve -d /tmp/tmp.db -p {{ .GRPCPort }}
+exec opm registry serve -d /tmp/tmp.db -p {{ .GRPCPort }}
 `
 
 // getContainerCmd uses templating to construct the container command

internal/olm/operator/registry/index/registry_pod_test.go

@@ -291,5 +291,5 @@ func containerCommandFor(dbPath string, items []BundleItem, hasCA, skipTLSVerify
 		additions.WriteString(fmt.Sprintf("opm registry add -d /tmp/tmp.db -b %s --mode=%s%s --skip-tls-verify=%v --use-http=%v && \\\n", item.ImageTag, item.AddMode, caFlag, skipTLSVerify, useHTTP))
 	}
 
-	return fmt.Sprintf("[[ -f %s ]] && cp %s /tmp/tmp.db; \\\n%sopm registry serve -d /tmp/tmp.db -p 50051\n", dbPath, dbPath, additions.String())
+	return fmt.Sprintf("[[ -f %s ]] && cp %s /tmp/tmp.db; \\\n%sexec opm registry serve -d /tmp/tmp.db -p 50051\n", dbPath, dbPath, additions.String())
 }