-
Notifications
You must be signed in to change notification settings - Fork 1.8k
bundle: createdAt field is always updated when make bundle is run #6285
Copy link
Copy link
Open
Labels
good first issueDenotes an issue ready for a new contributor, according to the "help wanted" guidelines.Denotes an issue ready for a new contributor, according to the "help wanted" guidelines.help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.kind/documentationCategorizes issue or PR as related to documentation.Categorizes issue or PR as related to documentation.language/goIssue is related to a Go operator projectIssue is related to a Go operator projectlifecycle/frozenIndicates that an issue or PR should not be auto-closed due to staleness.Indicates that an issue or PR should not be auto-closed due to staleness.
Milestone
Metadata
Metadata
Assignees
Labels
good first issueDenotes an issue ready for a new contributor, according to the "help wanted" guidelines.Denotes an issue ready for a new contributor, according to the "help wanted" guidelines.help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.kind/documentationCategorizes issue or PR as related to documentation.Categorizes issue or PR as related to documentation.language/goIssue is related to a Go operator projectIssue is related to a Go operator projectlifecycle/frozenIndicates that an issue or PR should not be auto-closed due to staleness.Indicates that an issue or PR should not be auto-closed due to staleness.
Type
Fields
Give feedbackNo fields configured for issues without a type.
Bug Report
Running
make bundlealways updates thecreatedAtfield even if no other updates in the bundle are present. I was hoping thatcreatedAtwould not change unless there are other changes in the bundle. I understand that this is an expected behaviour based on #6136, but it is annoying when taking git and github into account.I plan to create a github workflow that checks if
make bundlehas been run, and always having one line change is not ideal. The other place where this could be an issue is when collaborating on a project. The changes in the bundle will have to be actively ignored before commiting and pushing. Thegit pulloperation might complain that I have local changes and prevent me from pulling until they are discarded.I understand that there are ways around it, it is just not ideal to have to deal that.
What did you do?
Run
make bundle, commit all the changes.Run
make bundleagain.What did you expect to see?
I expected to see no changes in git
What did you see instead? Under which circumstances?
The line for
metadata.annotations.createdAtinbundle/manifests/<name>.clusterserviceversion.yamlis changed even though there are no other changes in the bundle.Environment
Operator type:
/language go
Kubernetes cluster type:
minikube
$ operator-sdk version$ go version(if language is Go)$ kubectl versionPossible Solution
Surround this with an if statement that checks if anything else has changed.
Additional context