scripts: add ignore-not-found for undeploy and uninstall to Makefile boiler plate#6842
scripts: add ignore-not-found for undeploy and uninstall to Makefile boiler plate#6842sgaist wants to merge 1 commit into
Conversation
sgaist
force-pushed
the
5195-add-ignore-not-found-to-undeploy
branch
3 times, most recently
from
f27a4d4 to
6366640
Compare
…boiler plate This avoid failure of any of these two commands if for some reason one or more of the kustomized resource is missing. Part of 5195 Signed-off-by: Samuel Gaist <samuel.gaist@idiap.ch>
sgaist
force-pushed
the
5195-add-ignore-not-found-to-undeploy
branch
from
6366640 to
666ed4f
Compare
sgaist
changed the title
|
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
openshift-ci
Bot
added
the
lifecycle/stale
|
Stale issues rot after 30d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle rotten |
openshift-ci
Bot
added
lifecycle/rotten
|
Rotten issues close after 30d of inactivity. Reopen the issue by commenting /close |
|
@openshift-bot: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/reopen |
|
@sgaist: Reopened this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Rotten issues close after 30d of inactivity. Reopen the issue by commenting /close |
|
@openshift-bot: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/reopen |
|
@sgaist: Reopened this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Hi @sgaist
Thank you for this PR 🥇
Those scaffolds came from Kubebuilder: https://github.com/kubernetes-sigs/kubebuilder
So, if we want to change the first step would be suggest the change there so that when we bump a new version we would have those added to the project.
We cannot change directly, that will not work.
If you run make generate, you will see that the changes will be undone
Hi @acornett21
I have no permission to close this one, but I think we could close it as not accepted. WDYT?
4 participants
Description of the change:
This PR adds the
--ignore-not-foundparameter to thekubectlcall when callingmake undeployandmake uninstall.Motivation for the change:
This avoid the failure of either command if for some reason one or more of the kustomized resource is missing.
Part of #5195
Checklist
If the pull request includes user-facing changes, extra documentation is required:
changelog/fragments(seechangelog/fragments/00-template.yaml)website/content/en/docs