Report work package creation accurately

Abort before POST when type resolution fails. Once creation
succeeds, report browser-launch problems as warnings so callers do not
retry and create duplicates.

Author: myabc

cmd/workpackage/create.go

@@ -1,6 +1,7 @@
 package workpackage
 
 import (
+	stderrors "errors"
 	"fmt"
 	"strconv"
 
@@ -41,14 +42,16 @@ func createWorkPackage(cmd *cobra.Command, args []string) error {
 
 	workPackage, err := work_packages.Create(createProjectId, createOptions(cmd, subject))
 	if err != nil {
-		printer.Error(err)
+		if !stderrors.Is(err, openerrors.ErrHandled) {
+			printer.Error(err)
+		}
 		return openerrors.ErrHandled
 	}
 
 	if createOpenInBrowser {
 		err = launch.Browser(routes.WorkPackageUrl(workPackage))
 		if err != nil {
-			printer.ErrorText(fmt.Sprintf("Error opening browser: %+v", err))
+			printer.Warning(fmt.Sprintf("Error opening browser: %+v", err))
 		}
 	} else {
 		printer.WorkPackage(workPackage)

cmd/workpackage/create_test.go

@@ -0,0 +1,43 @@
+package workpackage
+
+import (
+	"net/http"
+	"strings"
+	"testing"
+)
+
+func TestCreateBrowserFailureKeepsSuccessfulExit(t *testing.T) {
+	testingPrinter, requestCount := initWorkPackageTestServer(t, func(response http.ResponseWriter, request *http.Request) {
+		if request.Method != http.MethodPost {
+			t.Errorf("request method = %s, want POST", request.Method)
+		}
+		response.Header().Set("Content-Type", "application/json")
+		_, _ = response.Write([]byte(`{"id":42,"displayId":"42","subject":"Created"}`))
+	})
+
+	t.Setenv("PATH", t.TempDir())
+	createProjectId = "1"
+	createOpenInBrowser = true
+	createTypeFlag = ""
+	createAssigneeFlag = 0
+	createDescriptionFlag = ""
+	t.Cleanup(func() {
+		createProjectId = ""
+		createOpenInBrowser = false
+		createTypeFlag = ""
+		createAssigneeFlag = 0
+		createDescriptionFlag = ""
+	})
+
+	if err := createWorkPackage(createCmd, []string{"Created"}); err != nil {
+		t.Fatalf("createWorkPackage returned an error after the API create succeeded: %v", err)
+	}
+
+	if *requestCount != 1 {
+		t.Errorf("request count = %d, want 1", *requestCount)
+	}
+	if !strings.Contains(testingPrinter.ErrResult, "[WARNING]") ||
+		!strings.Contains(testingPrinter.ErrResult, "Error opening browser") {
+		t.Errorf("stderr should warn about the browser failure, got %q", testingPrinter.ErrResult)
+	}
+}

cmd/workpackage/test_helpers_test.go

@@ -0,0 +1,41 @@
+package workpackage
+
+import (
+	"net/http"
+	"net/http/httptest"
+	"net/url"
+	"testing"
+
+	"github.com/opf/openproject-cli/components/printer"
+	"github.com/opf/openproject-cli/components/requests"
+	"github.com/opf/openproject-cli/components/routes"
+)
+
+func initWorkPackageTestServer(t *testing.T, handler http.HandlerFunc) (*printer.TestingPrinter, *int) {
+	t.Helper()
+
+	requestCount := 0
+	server := httptest.NewServer(http.HandlerFunc(func(response http.ResponseWriter, request *http.Request) {
+		requestCount++
+		handler(response, request)
+	}))
+	t.Cleanup(server.Close)
+
+	host, err := url.Parse(server.URL)
+	if err != nil {
+		t.Fatal(err)
+	}
+	requests.Init(host, "", false)
+	routes.Init(host)
+
+	testingPrinter := &printer.TestingPrinter{}
+	printer.Init(testingPrinter)
+	if err := printer.InitRenderer("json"); err != nil {
+		t.Fatal(err)
+	}
+	t.Cleanup(func() {
+		_ = printer.InitRenderer("text")
+	})
+
+	return testingPrinter, &requestCount
+}

components/resources/work_packages/create.go

@@ -6,6 +6,7 @@ import (
 	"fmt"
 	"strconv"
 
+	openerrors "github.com/opf/openproject-cli/components/errors"
 	"github.com/opf/openproject-cli/components/parser"
 	"github.com/opf/openproject-cli/components/paths"
 	"github.com/opf/openproject-cli/components/printer"
@@ -50,10 +51,8 @@ func typeCreate(projectId string, workPackage *dtos.WorkPackageDto, input string
 			printer.Cyan(input),
 			printer.Red(projectId),
 		))
-
 		printer.Types(types.Convert())
-
-		return nil
+		return openerrors.ErrHandled
 	}
 
 	if workPackage.Links == nil {

components/resources/work_packages/create_test.go

@@ -0,0 +1,51 @@
+package work_packages_test
+
+import (
+	"errors"
+	"net/http"
+	"net/http/httptest"
+	"net/url"
+	"testing"
+
+	openerrors "github.com/opf/openproject-cli/components/errors"
+	"github.com/opf/openproject-cli/components/printer"
+	"github.com/opf/openproject-cli/components/requests"
+	"github.com/opf/openproject-cli/components/resources/work_packages"
+)
+
+func TestCreateRejectsInvalidTypeBeforePosting(t *testing.T) {
+	postCount := 0
+	server := httptest.NewServer(http.HandlerFunc(func(response http.ResponseWriter, request *http.Request) {
+		response.Header().Set("Content-Type", "application/json")
+		switch {
+		case request.Method == http.MethodGet && request.URL.Path == "/api/v3/projects/1":
+			_, _ = response.Write([]byte(`{"_links":{"types":{"href":"/api/v3/projects/1/types"}}}`))
+		case request.Method == http.MethodGet && request.URL.Path == "/api/v3/projects/1/types":
+			_, _ = response.Write([]byte(`{"_embedded":{"elements":[]}}`))
+		case request.Method == http.MethodPost:
+			postCount++
+			_, _ = response.Write([]byte(`{"id":42}`))
+		default:
+			http.Error(response, "unexpected request", http.StatusNotFound)
+		}
+	}))
+	t.Cleanup(server.Close)
+
+	host, err := url.Parse(server.URL)
+	if err != nil {
+		t.Fatal(err)
+	}
+	requests.Init(host, "", false)
+	printer.Init(&printer.TestingPrinter{})
+
+	_, err = work_packages.Create("1", map[work_packages.CreateOption]string{
+		work_packages.CreateSubject: "Subject",
+		work_packages.CreateType:    "Missing",
+	})
+	if !errors.Is(err, openerrors.ErrHandled) {
+		t.Fatalf("Create error = %v, want ErrHandled", err)
+	}
+	if postCount != 0 {
+		t.Errorf("POST count = %d, want 0", postCount)
+	}
+}