Propagate activity lookup failures

Return request failures from activity and user lookups instead of
printing and continuing. The command now emits one diagnostic and
stops before rendering incomplete activity data.

Author: myabc

cmd/activity/list.go

@@ -1,6 +1,8 @@
 package activity
 
 import (
+	stderrors "errors"
+
 	"github.com/spf13/cobra"
 
 	openerrors "github.com/opf/openproject-cli/components/errors"
@@ -29,7 +31,9 @@ func listActivities(_ *cobra.Command, _ []string) error {
 func listWorkPackageActivities(wpId string) error {
 	acts, err := work_packages.Activities(wpId)
 	if err != nil {
-		printer.ErrorText(err.Error())
+		if !stderrors.Is(err, openerrors.ErrHandled) {
+			printer.Error(err)
+		}
 		return openerrors.ErrHandled
 	}
 
@@ -40,7 +44,13 @@ func listWorkPackageActivities(wpId string) error {
 		}
 	}
 
-	userList := users.ByIds(userIds)
+	userList, err := users.ByIds(userIds)
+	if err != nil {
+		if !stderrors.Is(err, openerrors.ErrHandled) {
+			printer.Error(err)
+		}
+		return openerrors.ErrHandled
+	}
 	printer.Activities(acts, userList)
 	return nil
 }

cmd/activity/list_test.go

@@ -0,0 +1,88 @@
+package activity
+
+import (
+	"errors"
+	"net/http"
+	"net/http/httptest"
+	"net/url"
+	"strings"
+	"testing"
+
+	openerrors "github.com/opf/openproject-cli/components/errors"
+	"github.com/opf/openproject-cli/components/printer"
+	"github.com/opf/openproject-cli/components/requests"
+)
+
+func TestListWorkPackageActivitiesReportsFetchErrorsOnce(t *testing.T) {
+	server := httptest.NewServer(http.HandlerFunc(func(response http.ResponseWriter, _ *http.Request) {
+		http.Error(response, "activity failure", http.StatusInternalServerError)
+	}))
+	t.Cleanup(server.Close)
+
+	testingPrinter := initActivityTest(t, server.URL)
+	err := listWorkPackageActivities("42")
+
+	if !errors.Is(err, openerrors.ErrHandled) {
+		t.Fatalf("listWorkPackageActivities error = %v, want ErrHandled", err)
+	}
+	if count := strings.Count(testingPrinter.ErrResult, "[ERROR]"); count != 1 {
+		t.Errorf("error diagnostic count = %d, want 1; stderr: %q", count, testingPrinter.ErrResult)
+	}
+	if testingPrinter.Result != "" {
+		t.Errorf("stdout = %q, want empty", testingPrinter.Result)
+	}
+}
+
+func TestListWorkPackageActivitiesReportsUserFetchErrorsOnce(t *testing.T) {
+	server := httptest.NewServer(http.HandlerFunc(func(response http.ResponseWriter, request *http.Request) {
+		response.Header().Set("Content-Type", "application/json")
+		if request.URL.Path == "/api/v3/work_packages/42/activities" {
+			_, _ = response.Write([]byte(`{
+				"_embedded": {
+					"elements": [{
+						"id": 1,
+						"comment": {"raw": ""},
+						"details": [],
+						"_links": {"user": {"href": "/api/v3/users/7"}}
+					}]
+				}
+			}`))
+			return
+		}
+		http.Error(response, "user failure", http.StatusInternalServerError)
+	}))
+	t.Cleanup(server.Close)
+
+	testingPrinter := initActivityTest(t, server.URL)
+	err := listWorkPackageActivities("42")
+
+	if !errors.Is(err, openerrors.ErrHandled) {
+		t.Fatalf("listWorkPackageActivities error = %v, want ErrHandled", err)
+	}
+	if count := strings.Count(testingPrinter.ErrResult, "[ERROR]"); count != 1 {
+		t.Errorf("error diagnostic count = %d, want 1; stderr: %q", count, testingPrinter.ErrResult)
+	}
+	if testingPrinter.Result != "" {
+		t.Errorf("stdout = %q, want empty", testingPrinter.Result)
+	}
+}
+
+func initActivityTest(t *testing.T, serverURL string) *printer.TestingPrinter {
+	t.Helper()
+
+	host, err := url.Parse(serverURL)
+	if err != nil {
+		t.Fatal(err)
+	}
+	requests.Init(host, "", false)
+
+	testingPrinter := &printer.TestingPrinter{}
+	printer.Init(testingPrinter)
+	if err := printer.InitRenderer("json"); err != nil {
+		t.Fatal(err)
+	}
+	t.Cleanup(func() {
+		_ = printer.InitRenderer("text")
+	})
+	return testingPrinter
+}

components/resources/users/functions.go

@@ -4,16 +4,15 @@ import (
 	"github.com/opf/openproject-cli/components/common"
 	"github.com/opf/openproject-cli/components/parser"
 	"github.com/opf/openproject-cli/components/paths"
-	"github.com/opf/openproject-cli/components/printer"
 	"github.com/opf/openproject-cli/components/requests"
 	"github.com/opf/openproject-cli/components/resources"
 	"github.com/opf/openproject-cli/dtos"
 	"github.com/opf/openproject-cli/models"
 )
 
-func ByIds(ids []uint64) []*models.User {
+func ByIds(ids []uint64) ([]*models.User, error) {
 	if len(ids) == 0 {
-		return []*models.User{}
+		return []*models.User{}, nil
 	}
 	var filters []requests.Filter
 	filters = append(filters, IdFilter(ids))
@@ -24,11 +23,11 @@ func ByIds(ids []uint64) []*models.User {
 
 	response, err := requests.Get(requestUrl, &query)
 	if err != nil {
-		printer.Error(err)
+		return nil, err
 	}
 
 	userCollection := parser.Parse[dtos.UserCollectionDto](response)
-	return userCollection.Convert()
+	return userCollection.Convert(), nil
 }
 
 func Me() (*models.User, error) {

components/resources/work_packages/activities.go

@@ -3,7 +3,6 @@ package work_packages
 import (
 	"github.com/opf/openproject-cli/components/parser"
 	"github.com/opf/openproject-cli/components/paths"
-	"github.com/opf/openproject-cli/components/printer"
 	"github.com/opf/openproject-cli/components/requests"
 	"github.com/opf/openproject-cli/dtos"
 	"github.com/opf/openproject-cli/models"
@@ -12,7 +11,7 @@ import (
 func Activities(id string) (activites []*models.Activity, err error) {
 	response, err := requests.Get(paths.WorkPackageActivities(id), nil)
 	if err != nil {
-		printer.Error(err)
+		return nil, err
 	}
 
 	activitiesDto := parser.Parse[dtos.ActivityCollectionDto](response)