Fail when inspect cannot open a browser

Treat browser launch as part of read-only inspect commands. Return
a handled error so scripts do not mistake an unopened page for
success.

Author: myabc

cmd/project/inspect.go

@@ -42,6 +42,7 @@ func inspectProject(_ *cobra.Command, args []string) error {
 		err = launch.Browser(routes.ProjectUrl(project))
 		if err != nil {
 			printer.ErrorText(fmt.Sprintf("Error opening browser: %+v", err))
+			return openerrors.ErrHandled
 		}
 	} else {
 		printer.Project(project)

cmd/project/inspect_test.go

@@ -0,0 +1,49 @@
+package project
+
+import (
+	"errors"
+	"net/http"
+	"net/http/httptest"
+	"net/url"
+	"strings"
+	"testing"
+
+	openerrors "github.com/opf/openproject-cli/components/errors"
+	"github.com/opf/openproject-cli/components/printer"
+	"github.com/opf/openproject-cli/components/requests"
+	"github.com/opf/openproject-cli/components/routes"
+)
+
+func TestInspectBrowserFailureReturnsError(t *testing.T) {
+	server := httptest.NewServer(http.HandlerFunc(func(response http.ResponseWriter, request *http.Request) {
+		if request.Method != http.MethodGet {
+			t.Errorf("request method = %s, want GET", request.Method)
+		}
+		response.Header().Set("Content-Type", "application/json")
+		_, _ = response.Write([]byte(`{"id":1,"identifier":"example","name":"Example"}`))
+	}))
+	t.Cleanup(server.Close)
+
+	host, err := url.Parse(server.URL)
+	if err != nil {
+		t.Fatal(err)
+	}
+	requests.Init(host, "", false)
+	routes.Init(host)
+
+	testingPrinter := &printer.TestingPrinter{}
+	printer.Init(testingPrinter)
+	t.Setenv("PATH", t.TempDir())
+	openInBrowser = true
+	t.Cleanup(func() {
+		openInBrowser = false
+	})
+
+	err = inspectProject(nil, []string{"1"})
+	if !errors.Is(err, openerrors.ErrHandled) {
+		t.Fatalf("inspectProject error = %v, want ErrHandled", err)
+	}
+	if count := strings.Count(testingPrinter.ErrResult, "[ERROR]"); count != 1 {
+		t.Errorf("error diagnostic count = %d, want 1; stderr: %q", count, testingPrinter.ErrResult)
+	}
+}

cmd/workpackage/inspect.go

@@ -52,6 +52,7 @@ func inspectWorkPackage(_ *cobra.Command, args []string) error {
 		err = launch.Browser(routes.WorkPackageUrl(workPackage))
 		if err != nil {
 			printer.ErrorText(fmt.Sprintf("Error opening browser: %+v", err))
+			return openerrors.ErrHandled
 		}
 	} else {
 		printer.WorkPackage(workPackage)

cmd/workpackage/inspect_test.go

@@ -0,0 +1,37 @@
+package workpackage
+
+import (
+	"errors"
+	"net/http"
+	"strings"
+	"testing"
+
+	openerrors "github.com/opf/openproject-cli/components/errors"
+)
+
+func TestInspectBrowserFailureReturnsError(t *testing.T) {
+	testingPrinter, requestCount := initWorkPackageTestServer(t, func(response http.ResponseWriter, request *http.Request) {
+		if request.Method != http.MethodGet {
+			t.Errorf("request method = %s, want GET", request.Method)
+		}
+		response.Header().Set("Content-Type", "application/json")
+		_, _ = response.Write([]byte(`{"id":42,"displayId":"42","subject":"Example"}`))
+	})
+
+	t.Setenv("PATH", t.TempDir())
+	inspectOpenInBrowser = true
+	t.Cleanup(func() {
+		inspectOpenInBrowser = false
+	})
+
+	err := inspectWorkPackage(nil, []string{"42"})
+	if !errors.Is(err, openerrors.ErrHandled) {
+		t.Fatalf("inspectWorkPackage error = %v, want ErrHandled", err)
+	}
+	if *requestCount != 1 {
+		t.Errorf("request count = %d, want 1", *requestCount)
+	}
+	if count := strings.Count(testingPrinter.ErrResult, "[ERROR]"); count != 1 {
+		t.Errorf("error diagnostic count = %d, want 1; stderr: %q", count, testingPrinter.ErrResult)
+	}
+}