Report activity lookup failures only once

activityCreate printed guidance and then returned a plain error that
the command layer reported a second time, so failures showed twice.
Return ErrHandled from the paths that already printed, and skip
re-reporting it in the caller, matching how work_packages signals an
already-reported error.

Author: myabc

cmd/timeentry/create.go

@@ -1,6 +1,7 @@
 package timeentry
 
 import (
+	stderrors "errors"
 	"strconv"
 	"time"
 
@@ -57,7 +58,9 @@ func createTimeEntry(cmd *cobra.Command, _ []string) error {
 
 	entry, err := time_entries.Create(options)
 	if err != nil {
-		printer.Error(err)
+		if !stderrors.Is(err, openerrors.ErrHandled) {
+			printer.Error(err)
+		}
 		return openerrors.ErrHandled
 	}
 

components/resources/time_entries/activity_error_test.go

@@ -0,0 +1,50 @@
+package time_entries
+
+import (
+	stderrors "errors"
+	"net/http"
+	"net/http/httptest"
+	"net/url"
+	"testing"
+
+	openerrors "github.com/opf/openproject-cli/components/errors"
+	"github.com/opf/openproject-cli/components/printer"
+	"github.com/opf/openproject-cli/components/requests"
+)
+
+// An unresolved --activity is already reported inside the resource layer, so
+// Create must return ErrHandled (not a fresh error the caller re-prints) and
+// must not POST the time entry.
+func TestCreateUnknownActivityReturnsErrHandled(t *testing.T) {
+	postCount := 0
+	server := httptest.NewServer(http.HandlerFunc(func(response http.ResponseWriter, request *http.Request) {
+		response.Header().Set("Content-Type", "application/json")
+		switch {
+		case request.Method == http.MethodGet && request.URL.Path == "/api/v3/time_entries/activities":
+			_, _ = response.Write([]byte(`{"_embedded":{"elements":[{"id":1,"name":"Development"}]}}`))
+		case request.Method == http.MethodPost:
+			postCount++
+			_, _ = response.Write([]byte(`{"id":1}`))
+		default:
+			http.Error(response, "unexpected request", http.StatusNotFound)
+		}
+	}))
+	t.Cleanup(server.Close)
+
+	host, err := url.Parse(server.URL)
+	if err != nil {
+		t.Fatal(err)
+	}
+	requests.Init(host, "", false)
+	printer.Init(&printer.TestingPrinter{})
+
+	_, err = Create(map[CreateOption]string{
+		CreateActivity: "no-such-activity",
+	})
+	if !stderrors.Is(err, openerrors.ErrHandled) {
+		t.Fatalf("Create error = %v, want ErrHandled", err)
+	}
+	if postCount != 0 {
+		t.Errorf("POST count = %d, want 0", postCount)
+	}
+}

components/resources/time_entries/create.go

@@ -9,6 +9,7 @@ import (
 	"strings"
 	"time"
 
+	openerrors "github.com/opf/openproject-cli/components/errors"
 	"github.com/opf/openproject-cli/components/parser"
 	"github.com/opf/openproject-cli/components/paths"
 	"github.com/opf/openproject-cli/components/printer"
@@ -97,7 +98,7 @@ func activityCreate(entry *dtos.TimeEntryDto, input string) error {
 	if err != nil {
 		printer.ErrorText(fmt.Sprintf("Could not fetch available activities: %s", err))
 		printer.Info("Use `op time-entry list` to see existing entries and their activities.")
-		return fmt.Errorf("activity lookup failed")
+		return openerrors.ErrHandled
 	}
 
 	if strings.TrimSpace(input) == "" {
@@ -111,7 +112,7 @@ func activityCreate(entry *dtos.TimeEntryDto, input string) error {
 		for _, a := range candidates {
 			printer.Info(fmt.Sprintf("  - %s", a.Name))
 		}
-		return fmt.Errorf("activity %q is ambiguous", input)
+		return openerrors.ErrHandled
 	}
 	if found == nil {
 		printer.ErrorText(fmt.Sprintf("No activity matching %q found.", input))
@@ -121,7 +122,7 @@ func activityCreate(entry *dtos.TimeEntryDto, input string) error {
 				printer.Info(fmt.Sprintf("  - %s", a.Name))
 			}
 		}
-		return fmt.Errorf("activity %q not found", input)
+		return openerrors.ErrHandled
 	}
 
 	if entry.Links == nil {