Render empty searches as JSON arrays

Always invoke the collection renderer, even when a search has no
matches. JSON callers now receive [] while text users still get an
empty-result diagnostic on standard error.

Author: myabc

cmd/user/search.go

@@ -25,8 +25,9 @@ func searchUser(_ *cobra.Command, args []string) error {
 		printer.ErrorText(fmt.Sprintf("Expected 1 argument [searchInput], but got %d", len(args)))
 		return openerrors.ErrHandled
 	}
+	query := args[0]
 
-	if common.Contains(keywords, args[0]) {
+	if common.Contains(keywords, query) {
 		me, err := users.Me()
 		if err != nil {
 			printer.Error(err)
@@ -36,16 +37,15 @@ func searchUser(_ *cobra.Command, args []string) error {
 		return nil
 	}
 
-	collection, err := users.Search(args[0])
+	collection, err := users.Search(query)
 	if err != nil {
 		printer.Error(err)
 		return openerrors.ErrHandled
 	}
 
 	if len(collection) == 0 {
-		printer.Info(fmt.Sprintf("No user found for search input %s.", printer.Cyan(args[0])))
-	} else {
-		printer.Users(collection)
+		printer.Info(fmt.Sprintf("No user found for search input %s.", printer.Cyan(query)))
 	}
+	printer.Users(collection)
 	return nil
 }

cmd/user/search_test.go

@@ -0,0 +1,71 @@
+package user
+
+import (
+	"net/http"
+	"net/http/httptest"
+	"net/url"
+	"strings"
+	"testing"
+
+	"github.com/opf/openproject-cli/components/printer"
+	"github.com/opf/openproject-cli/components/requests"
+)
+
+func TestSearchUsersRendersEmptyJSONArray(t *testing.T) {
+	server := httptest.NewServer(http.HandlerFunc(func(response http.ResponseWriter, _ *http.Request) {
+		response.Header().Set("Content-Type", "application/json")
+		_, _ = response.Write([]byte(`{"_embedded":{"elements":[]},"total":0,"count":0}`))
+	}))
+	t.Cleanup(server.Close)
+
+	host, err := url.Parse(server.URL)
+	if err != nil {
+		t.Fatal(err)
+	}
+	requests.Init(host, "", false)
+
+	testingPrinter := &printer.TestingPrinter{}
+	printer.Init(testingPrinter)
+	if err := printer.InitRenderer("json"); err != nil {
+		t.Fatal(err)
+	}
+	t.Cleanup(func() {
+		_ = printer.InitRenderer("text")
+	})
+
+	if err := searchUser(nil, []string{"missing person"}); err != nil {
+		t.Fatalf("searchUser returned an error: %v", err)
+	}
+
+	if testingPrinter.Result != "[]\n" {
+		t.Errorf("stdout = %q, want %q", testingPrinter.Result, "[]\n")
+	}
+	if !strings.Contains(testingPrinter.ErrResult, "missing person") {
+		t.Errorf("stderr should contain the complete query, got %q", testingPrinter.ErrResult)
+	}
+}
+
+func TestSearchUserRequiresOneArgument(t *testing.T) {
+	requestCount := 0
+	server := httptest.NewServer(http.HandlerFunc(func(response http.ResponseWriter, _ *http.Request) {
+		requestCount++
+		_, _ = response.Write([]byte(`{"_embedded":{"elements":[]}}`))
+	}))
+	t.Cleanup(server.Close)
+
+	host, err := url.Parse(server.URL)
+	if err != nil {
+		t.Fatal(err)
+	}
+	requests.Init(host, "", false)
+
+	testingPrinter := &printer.TestingPrinter{}
+	printer.Init(testingPrinter)
+
+	if err := searchUser(nil, []string{"missing", "person"}); err == nil {
+		t.Fatal("searchUser returned nil for two arguments")
+	}
+	if requestCount != 0 {
+		t.Errorf("request count = %d, want 0", requestCount)
+	}
+}

cmd/workpackage/search.go

@@ -49,8 +49,7 @@ func searchWorkPackages(_ *cobra.Command, args []string) error {
 
 	if len(collection) == 0 {
 		printer.Info(fmt.Sprintf("No work package found for search input %s.", printer.Cyan(query)))
-	} else {
-		printer.WorkPackages(collection)
 	}
+	printer.WorkPackages(collection)
 	return nil
 }

cmd/workpackage/search_test.go

@@ -0,0 +1,25 @@
+package workpackage
+
+import (
+	"net/http"
+	"strings"
+	"testing"
+)
+
+func TestSearchWorkPackagesRendersEmptyJSONArray(t *testing.T) {
+	testingPrinter, _ := initWorkPackageTestServer(t, func(response http.ResponseWriter, _ *http.Request) {
+		response.Header().Set("Content-Type", "application/json")
+		_, _ = response.Write([]byte(`{"_embedded":{"elements":[]},"total":0,"count":0}`))
+	})
+
+	if err := searchWorkPackages(nil, []string{"missing"}); err != nil {
+		t.Fatalf("searchWorkPackages returned an error: %v", err)
+	}
+
+	if testingPrinter.Result != "[]\n" {
+		t.Errorf("stdout = %q, want %q", testingPrinter.Result, "[]\n")
+	}
+	if !strings.Contains(testingPrinter.ErrResult, "No work package found") {
+		t.Errorf("stderr should describe the empty result, got %q", testingPrinter.ErrResult)
+	}
+}