Validate work package updates up front

Resolve actions, patch values, and attachment paths before the
first mutation. This prevents local validation errors from leaving
earlier changes applied while preserving lock-version refreshes.

Attachment validation also requires the addAttachment link and
rejects fog storages before any mutation, so a missing upload
capability surfaces as an error instead of a panic after the
action and patch have already run.

Author: myabc

cmd/workpackage/options_test.go

@@ -1,10 +1,14 @@
 package workpackage
 
 import (
+	"errors"
+	"strings"
 	"testing"
 
 	"github.com/spf13/cobra"
 
+	openerrors "github.com/opf/openproject-cli/components/errors"
+	"github.com/opf/openproject-cli/components/printer"
 	"github.com/opf/openproject-cli/components/resources/work_packages"
 )
 
@@ -65,3 +69,31 @@ func TestUpdateOptions_DescriptionProvided(t *testing.T) {
 		t.Error("expected UpdateDescription to be present when flag explicitly provided with empty string")
 	}
 }
+
+func TestUpdateWithoutOptionsStopsBeforeRequest(t *testing.T) {
+	updateActionFlag = ""
+	updateAssigneeFlag = 0
+	updateAttachFlag = ""
+	updateDescriptionFlag = ""
+	updateSubjectFlag = ""
+	updateTypeFlag = ""
+
+	cmd := newCmdWithDescriptionFlag(&updateDescriptionFlag)
+	if err := cmd.Flags().Parse(nil); err != nil {
+		t.Fatal(err)
+	}
+
+	testingPrinter := &printer.TestingPrinter{}
+	printer.Init(testingPrinter)
+
+	err := updateWorkPackage(cmd, []string{"42"})
+	if !errors.Is(err, openerrors.ErrHandled) {
+		t.Fatalf("updateWorkPackage error = %v, want ErrHandled", err)
+	}
+	if !strings.Contains(testingPrinter.ErrResult, "No update options provided") {
+		t.Errorf("stderr = %q, want no-options diagnostic", testingPrinter.ErrResult)
+	}
+	if strings.Contains(testingPrinter.ErrResult, "Cannot execute requests") {
+		t.Errorf("command attempted a request: %q", testingPrinter.ErrResult)
+	}
+}

cmd/workpackage/update.go

@@ -1,6 +1,7 @@
 package workpackage
 
 import (
+	stderrors "errors"
 	"fmt"
 	"strconv"
 
@@ -38,9 +39,17 @@ func updateWorkPackage(cmd *cobra.Command, args []string) error {
 		return openerrors.ErrHandled
 	}
 
-	workPackage, err := work_packages.Update(id, updateOptions(cmd))
+	options := updateOptions(cmd)
+	if len(options) == 0 {
+		printer.ErrorText("No update options provided. Use --help to see available flags.")
+		return openerrors.ErrHandled
+	}
+
+	workPackage, err := work_packages.Update(id, options)
 	if err != nil {
-		printer.Error(err)
+		if !stderrors.Is(err, openerrors.ErrHandled) {
+			printer.Error(err)
+		}
 		return openerrors.ErrHandled
 	}
 

components/resources/work_packages/custom_actions.go

@@ -7,14 +7,15 @@ import (
 	"strings"
 
 	"github.com/opf/openproject-cli/components/common"
+	openerrors "github.com/opf/openproject-cli/components/errors"
 	"github.com/opf/openproject-cli/components/parser"
 	"github.com/opf/openproject-cli/components/printer"
 	"github.com/opf/openproject-cli/components/requests"
 	"github.com/opf/openproject-cli/dtos"
 	"github.com/opf/openproject-cli/models"
 )
 
-func action(workPackage *dtos.WorkPackageDto, action string) error {
+func resolveAction(workPackage *dtos.WorkPackageDto, action string) (*dtos.CustomActionDto, error) {
 	foundAction := findAction(action, workPackage.Embedded.CustomActions)
 	if foundAction == nil {
 		printer.ErrorText("Failed to execute work package custom action.")
@@ -31,10 +32,10 @@ func action(workPackage *dtos.WorkPackageDto, action string) error {
 			[]*models.CustomAction{},
 		)
 		printer.CustomActions(availableActions)
-		return nil
+		return nil, openerrors.ErrHandled
 	}
 
-	return executeAction(workPackage, foundAction)
+	return foundAction, nil
 }
 
 func findAction(actionInput string, availableActions []*dtos.CustomActionDto) *dtos.CustomActionDto {

components/resources/work_packages/update.go

@@ -4,9 +4,11 @@ import (
 	"bytes"
 	"encoding/json"
 	"fmt"
+	"os"
 	"strconv"
 
 	"github.com/opf/openproject-cli/components/common"
+	openerrors "github.com/opf/openproject-cli/components/errors"
 	"github.com/opf/openproject-cli/components/parser"
 	"github.com/opf/openproject-cli/components/paths"
 	"github.com/opf/openproject-cli/components/printer"
@@ -41,8 +43,27 @@ func Update(id string, options map[UpdateOption]string) (*models.WorkPackage, er
 		return nil, err
 	}
 
-	if customAction, ok := options[UpdateCustomAction]; ok {
-		err = action(workPackage, customAction)
+	var customAction *dtos.CustomActionDto
+	if input, ok := options[UpdateCustomAction]; ok {
+		customAction, err = resolveAction(workPackage, input)
+		if err != nil {
+			return nil, err
+		}
+	}
+
+	patchDto, updateString, patchNeeded, err := preparePatch(workPackage, options)
+	if err != nil {
+		return nil, err
+	}
+
+	if file, ok := options[UpdateAttachment]; ok {
+		if err := validateAttachment(workPackage, file); err != nil {
+			return nil, err
+		}
+	}
+
+	if customAction != nil {
+		err = executeAction(workPackage, customAction)
 		if err != nil {
 			return nil, err
 		}
@@ -54,9 +75,11 @@ func Update(id string, options map[UpdateOption]string) (*models.WorkPackage, er
 		}
 	}
 
-	err = patch(workPackage, options)
-	if err != nil {
-		return nil, err
+	if patchNeeded {
+		patchDto.LockVersion = workPackage.LockVersion
+		if err := executePatch(workPackage, patchDto, updateString); err != nil {
+			return nil, err
+		}
 	}
 
 	if file, ok := options[UpdateAttachment]; ok {
@@ -74,9 +97,9 @@ func Update(id string, options map[UpdateOption]string) (*models.WorkPackage, er
 	return workPackage.Convert(), nil
 }
 
-func patch(workPackage *dtos.WorkPackageDto, options map[UpdateOption]string) error {
+func preparePatch(workPackage *dtos.WorkPackageDto, options map[UpdateOption]string) (*dtos.WorkPackageDto, string, bool, error) {
 	var patchNeeded = false
-	patchDto := dtos.WorkPackageDto{LockVersion: workPackage.LockVersion}
+	patchDto := &dtos.WorkPackageDto{}
 	var updateString string
 
 	for option, value := range options {
@@ -85,9 +108,9 @@ func patch(workPackage *dtos.WorkPackageDto, options map[UpdateOption]string) er
 		}
 
 		patchNeeded = true
-		updateStringLine, err := patchMap[option](&patchDto, workPackage, value)
+		updateStringLine, err := patchMap[option](patchDto, workPackage, value)
 		if err != nil {
-			return err
+			return nil, "", false, err
 		}
 
 		if len(updateStringLine) > 0 {
@@ -98,10 +121,10 @@ func patch(workPackage *dtos.WorkPackageDto, options map[UpdateOption]string) er
 		}
 	}
 
-	if !patchNeeded {
-		return nil
-	}
+	return patchDto, updateString, patchNeeded, nil
+}
 
+func executePatch(workPackage, patchDto *dtos.WorkPackageDto, updateString string) error {
 	printer.Info("Updating work package with patch ...")
 
 	marshal, err := json.Marshal(patchDto)
@@ -119,6 +142,30 @@ func patch(workPackage *dtos.WorkPackageDto, options map[UpdateOption]string) er
 	return nil
 }
 
+func validateAttachment(workPackage *dtos.WorkPackageDto, path string) error {
+	if workPackage.Links.PrepareAttachment != nil {
+		return fmt.Errorf("uploads to fog storages are currently not supported")
+	}
+	if workPackage.Links.AddAttachment == nil {
+		return fmt.Errorf("this work package does not accept attachments (missing permission?)")
+	}
+
+	file, err := os.Open(path)
+	if err != nil {
+		return err
+	}
+	defer func() { _ = file.Close() }()
+
+	info, err := file.Stat()
+	if err != nil {
+		return err
+	}
+	if info.IsDir() {
+		return fmt.Errorf("attachment path %q is a directory", path)
+	}
+	return nil
+}
+
 func typePatch(patch, workPackage *dtos.WorkPackageDto, input string) (string, error) {
 	types, err := availableTypes(workPackage.Links.Project)
 	if err != nil {
@@ -136,7 +183,7 @@ func typePatch(patch, workPackage *dtos.WorkPackageDto, input string) (string, e
 
 		printer.Types(types.Convert())
 
-		return "", nil
+		return "", openerrors.ErrHandled
 	}
 
 	if patch.Links == nil {