[#73750] Additional contract and resource specs

Author: EinLama

modules/backlogs/spec/contracts/work_packages/shared_contract_examples.rb

@@ -125,6 +125,21 @@
       it_behaves_like "contract is invalid", sprint: :not_shared_with_project
     end
 
+    context "when sprint is completed (shared with project but not assignable)" do
+      let(:completed_sprint) { build_stubbed(:agile_sprint, status: :completed) }
+      let(:work_package_sprint) { completed_sprint }
+
+      before do
+        # The sprint is still shared with the project (the outer before mock makes
+        # `Agile::Sprint.for_project.exists?` return true), so `sprint_shared_with_project`
+        # passes. We stub assignable_sprints to exclude it, simulating the `.not_completed`
+        # scope, so only `validate_sprint_is_assignable` fires.
+        allow(work_package_project).to receive(:assignable_sprints).and_return([])
+      end
+
+      it_behaves_like "contract is invalid", sprint_id: :inclusion
+    end
+
     context "when sprint is set while the user lacks the :manage_sprint_items permission" do
       let(:effective_permissions) { permissions - [:manage_sprint_items] }
 

modules/backlogs/spec/requests/api/v3/work_packages/create_resource_spec.rb

@@ -40,6 +40,7 @@
   shared_let(:status) { create(:status, is_default: true) }
   shared_let(:priority) { create(:priority, is_default: true) }
   shared_let(:sprint) { create(:agile_sprint, project:) }
+  shared_let(:completed_sprint) { create(:agile_sprint, project:, status: :completed) }
   shared_let(:outside_sprint) { create(:agile_sprint, project: create(:project)) }
 
   let(:role) { create(:project_role, permissions:) }
@@ -104,6 +105,30 @@
       end
     end
 
+    context "when attempting to create the work package on a completed sprint" do
+      let(:parameters) do
+        {
+          subject: "new work packages",
+          storyPoints: 5,
+          _links: {
+            type: {
+              href: api_v3_paths.type(type.id)
+            },
+            project: {
+              href: api_v3_paths.project(project.id)
+            },
+            sprint: {
+              href: api_v3_paths.sprint(completed_sprint.id)
+            }
+          }
+        }
+      end
+
+      it_behaves_like "constraint violation" do
+        let(:message) { "Sprint is not set to one of the allowed values." }
+      end
+    end
+
     context "when attempting to create the work package on a non valid sprint" do
       let(:parameters) do
         {

modules/backlogs/spec/requests/api/v3/work_packages/update_resource_spec.rb

@@ -41,6 +41,7 @@
   shared_let(:status) { create(:status, is_default: true) }
   shared_let(:priority) { create(:priority, is_default: true) }
   shared_let(:sprint) { create(:agile_sprint, project:) }
+  shared_let(:completed_sprint) { create(:agile_sprint, project:, status: :completed) }
   shared_let(:outside_sprint) { create(:agile_sprint, project: other_project) }
   shared_let(:work_package) { create(:work_package, project:, type:, status:, priority:) }
 
@@ -138,6 +139,24 @@
       it_behaves_like "read-only violation", "subject", WorkPackage
     end
 
+    context "when attempting to assign the work package to a completed sprint" do
+      let(:parameters) do
+        {
+          storyPoints: 5,
+          lockVersion: work_package.lock_version,
+          _links: {
+            sprint: {
+              href: api_v3_paths.sprint(completed_sprint.id)
+            }
+          }
+        }
+      end
+
+      it_behaves_like "constraint violation" do
+        let(:message) { "Sprint is not set to one of the allowed values." }
+      end
+    end
+
     context "when attempting to assign the work package to a non valid sprint" do
       let(:other_permissions) { [] }
       let(:parameters) do