Test numeric ID button in WP context menu specs

Author: thykel

spec/features/work_packages/details/context_menu_spec.rb

@@ -30,4 +30,24 @@
     # It can either succeed (showing success message) or fail (showing the URL to copy manually).
     expect(page).to have_message_copied_to_clipboard("/wp/#{work_package.id}")
   end
+
+  describe "'Copy numeric ID to clipboard' item" do
+    context "in classic (numeric) mode", with_settings: { work_packages_identifier: "classic" } do
+      it "is not offered (the displayed id is already the numeric id)" do
+        find("button[wpsinglecontextmenu]").click
+        within(".op-context-menu--overlay") do
+          expect(page).to have_no_css(".menu-item", text: "Copy numeric ID to clipboard")
+        end
+      end
+    end
+
+    context "in semantic mode", with_settings: { work_packages_identifier: "semantic" } do
+      it "is offered" do
+        find("button[wpsinglecontextmenu]").click
+        within(".op-context-menu--overlay") do
+          expect(page).to have_css(".menu-item", text: "Copy numeric ID to clipboard")
+        end
+      end
+    end
+  end
 end

spec/features/work_packages/table/semantic_id_navigation_follow_ups_spec.rb

@@ -84,6 +84,48 @@
     end
   end
 
+  describe "right-click context menu 'Copy numeric ID to clipboard' item" do
+    it "copies the numeric id and does not navigate away (regression: used to 404)" do
+      numeric_id = work_package.id.to_s
+      semantic_id = work_package.reload.identifier
+
+      # Spy directly on navigator.clipboard.writeText (see the sibling
+      # 'Copy link to clipboard' example for why the flash matcher won't do).
+      page.execute_script(<<~JS)
+        window.__lastCopiedText = null;
+        navigator.clipboard.writeText = function(text) {
+          window.__lastCopiedText = text;
+          return Promise.resolve();
+        };
+      JS
+
+      context_menu.open_for(work_package)
+      context_menu.choose("Copy numeric ID to clipboard")
+
+      copied = nil
+      retry_block do
+        copied = page.evaluate_script("window.__lastCopiedText")
+        raise "clipboard write not yet observed" if copied.nil?
+      end
+
+      expect(copied).to eq(numeric_id)
+      expect(copied).not_to eq(semantic_id)
+
+      # The action used to fall through to `window.location.href = undefined`,
+      # navigating to a non-existent URL. It must stay on the table instead.
+      wp_table.expect_work_package_listed(work_package, other_wp)
+    end
+  end
+
+  context "in classic (numeric) mode", with_settings: { work_packages_identifier: "classic" } do
+    describe "right-click context menu 'Copy numeric ID to clipboard' item" do
+      it "is not offered (the displayed id is already the numeric id)" do
+        context_menu.open_for(work_package)
+        context_menu.expect_no_options("Copy numeric ID to clipboard")
+      end
+    end
+  end
+
   describe "toolbar info icon" do
     it "opens the split view at the semantic identifier URL" do
       semantic_id = work_package.reload.identifier