Add handling for indeterminate checkboxes

Author: mrmir

app/controllers/workflows/tabs_controller.rb

@@ -57,9 +57,12 @@ def update # rubocop:disable Metrics/AbcSize
     success = false
     Workflow.transaction do
       success = true
+      base_params = permitted_status_params
+      indeterminate = permitted_indeterminate_params
       @roles.each do |role|
+        role_params = indeterminate.empty? ? base_params : role_specific_params(base_params, indeterminate, role)
         result = Workflows::BulkUpdateService.new(role:, type: @type, tab: @tab)
-                                             .call(permitted_status_params)
+                                             .call(role_params)
         success = false unless result.success?
       end
       raise ActiveRecord::Rollback unless success
@@ -200,10 +203,40 @@ def workflows_for_form
   end
 
   def permitted_status_params
-    return {} if params["status"].blank?
+    status_params("status")
+  end
+
+  def permitted_indeterminate_params
+    status_params("indeterminate_status")
+  end
 
-    params["status"]
+  def status_params(key)
+    return {} if params[key].blank?
+
+    params[key]
       .to_unsafe_h
-      .select { |key, value| /\A\d+\z/.match?(key) && value.keys.all? { /\A\d+\z/.match?(it) } }
+      .select { |k, value| /\A\d+\z/.match?(k) && value.keys.all? { /\A\d+\z/.match?(it) } }
+  end
+
+  def role_specific_params(base_params, indeterminate, role)
+    params = base_params.deep_dup
+    indeterminate.each do |old_id, new_ids|
+      new_ids.each_key do |new_id|
+        # Restore from DB so that it isn't overwritten by indeterminate state (unchecked)
+        had_transition = Workflow.exists?(
+          role_id: role.id,
+          type_id: @type.id,
+          old_status_id: old_id.to_i,
+          new_status_id: new_id.to_i,
+          author: @tab == "author",
+          assignee: @tab == "assignee"
+        )
+        if had_transition
+          params[old_id] ||= {}
+          params[old_id][new_id] = "1"
+        end
+      end
+    end
+    params
   end
 end

app/views/workflows/_form.html.erb

@@ -191,6 +191,7 @@ See COPYRIGHT and LICENSE files for more details.
                  newly_added_status = @added_status_ids.include?(old_status.id) || @added_status_ids.include?(new_status.id)
                  some_roles = !transition_role_ids.empty? && transition_role_ids.size < @roles.size && !newly_added_status %>
               <td>
+                <%= hidden_field_tag "indeterminate_status[#{old_status.id}][#{new_status.id}]", "1" if some_roles %>
                 <%=
                   render(Primer::BaseComponent.new(tag: :div, display: :flex, align_items: :center, mx: 1)) do
                     render(
@@ -199,7 +200,7 @@ See COPYRIGHT and LICENSE files for more details.
                         name: "status[#{old_status.id}][#{new_status.id}]",
                         id: "status_#{old_status.id}_#{new_status.id}", # See BUG https://github.com/primer/view_components/issues/3811
                         value: name,
-                        checked: transition_role_ids.any? || newly_added_status,
+                        checked: !some_roles && (transition_role_ids.any? || newly_added_status),
                         label: t(".matrix_checkbox_label", old_status: old_status.name, new_status: new_status.name),
                         visually_hide_label: true,
                         data: {

frontend/src/stimulus/controllers/dynamic/admin/workflow-checkbox-state.controller.ts

@@ -82,7 +82,7 @@ export default class WorkflowCheckboxStateController extends Controller<HTMLForm
     if (statusCheckboxes) {
       this.applyState(statusCheckboxes);
       // Recompute dirty flag: the restored state may differ from DB pristine.
-      this.onCheckboxChange();
+      this.recomputeDirtyFlag();
     } else {
       // Apply indeterminate checkboxes only on fresh server rendered content.
       this.initIndeterminateCheckboxes();
@@ -264,12 +264,24 @@ export default class WorkflowCheckboxStateController extends Controller<HTMLForm
     window.OpenProject.pageState = hasChanges ? 'edited' : 'pristine';
   }
 
-  private onCheckboxChange = () => {
+  private onCheckboxChange = (event:Event) => {
+    this.removeIndeterminateMarker(event.target as HTMLInputElement);
+    this.recomputeDirtyFlag();
+  };
+
+  private recomputeDirtyFlag() {
     const current = this.captureState();
     const hasChanges = Object.keys(current).some((key) => current[key] !== this.initialCheckboxState[key]);
 
     this.hasCheckboxChangesValue = hasChanges;
-  };
+  }
+
+  private removeIndeterminateMarker(checkbox:HTMLInputElement):void {
+    const { oldStatus, newStatus } = checkbox.dataset;
+    this.element.querySelector<HTMLInputElement>(
+      `input[name="indeterminate_status[${oldStatus}][${newStatus}]"]`,
+    )?.remove();
+  }
 
   private captureState():Record<string, boolean> {
     const checkboxes:Record<string, boolean> = {};