Merge pull request #23732 from opf/code-maintenance/OP-19544-remove-lodash-set-dedup

[OP-19544] Replace lodash set/dedup helpers with native

Author: myabc

frontend/src/app/core/apiv3/endpoints/relations/apiv3-relations-paths.ts

@@ -57,7 +57,7 @@ export class ApiV3RelationsPaths extends ApiV3ResourceCollection<RelationResourc
       const chunks = chunk(workPackageIds, MAGIC_RELATION_SIZE);
       return forkJoin(chunks.map((chunk) => this.loadInvolved(chunk)))
         .pipe(
-          map((results) => _.flatten(results)),
+          map((results) => results.flat()),
         );
     }
 

frontend/src/app/core/apiv3/endpoints/work_packages/api-v3-work-packages-paths.ts

@@ -70,7 +70,7 @@ export class ApiV3WorkPackagesPaths extends ApiV3Collection<WorkPackageResource,
 
     return new Promise<undefined>((resolve, reject) => {
       this
-        .loadCollectionsFor(_.uniq(ids))
+        .loadCollectionsFor(Array.from(new Set(ids)))
         .then((pagedResults:WorkPackageCollectionResource[]) => {
           pagedResults.forEach((results) => {
             if (results.schemas) {

frontend/src/app/features/hal/resources/error-resource.ts

@@ -94,20 +94,20 @@ export class ErrorResource extends HalResource {
   }
 
   public getInvolvedAttributes():string[] {
-    let columns = [];
+    let columns:ErrorResource[] = [];
 
     if (this.details) {
-      columns = [{ details: this.details }];
+      columns = [{ details: this.details as { attribute:string } } as ErrorResource];
     } else if (this.errors) {
-      columns = this.errors;
+      columns = this.errors as ErrorResource[];
     }
 
-    return _.flatten(columns.map((resource:ErrorResource) => {
+    return columns.map((resource:ErrorResource):string => {
       if (resource.errorIdentifier === v3ErrorIdentifierMultipleErrors) {
         return this.extractMultiError(resource)[0];
       }
-      return resource.details.attribute;
-    }));
+      return (resource.details as { attribute:string }).attribute;
+    }).flat();
   }
 
   public getMessagesPerAttribute():Record<string, string[]> {

frontend/src/app/features/hal/resources/hal-resource.ts

@@ -287,7 +287,7 @@ export class HalResource {
    */
   public $embeddableKeys():string[] {
     const properties = Object.keys(this.$source);
-    return _.without(properties, '_links', '_embedded', 'id');
+    return properties.filter((property) => !['_links', '_embedded', 'id'].includes(property));
   }
 
   /**
@@ -296,6 +296,6 @@ export class HalResource {
    */
   public $linkableKeys():string[] {
     const properties = Object.keys(this.$links);
-    return _.without(properties, 'self');
+    return properties.filter((property) => property !== 'self');
   }
 }

frontend/src/app/features/hal/resources/project-resource.ts

@@ -51,6 +51,6 @@ export class ProjectResource extends HalResource {
    * Exclude the schema _link from the linkable Resources.
    */
   public $linkableKeys():string[] {
-    return _.without(super.$linkableKeys(), 'schema');
+    return super.$linkableKeys().filter((key) => key !== 'schema');
   }
 }

frontend/src/app/features/hal/resources/time-entry-resource.ts

@@ -56,7 +56,7 @@ export class TimeEntryResource extends HalResource {
    * Exclude the schema _link from the linkable Resources.
    */
   public $linkableKeys():string[] {
-    return _.without(super.$linkableKeys(), 'schema');
+    return super.$linkableKeys().filter((key) => key !== 'schema');
   }
 }
 

frontend/src/app/features/hal/resources/work-package-resource.ts

@@ -297,7 +297,7 @@ export class WorkPackageBaseResource extends HalResource {
    * Exclude the schema _link from the linkable Resources.
    */
   public $linkableKeys():string[] {
-    return _.without(super.$linkableKeys(), 'schema');
+    return super.$linkableKeys().filter((key) => key !== 'schema');
   }
 
   /**

frontend/src/app/features/in-app-notifications/entry/actors-line/in-app-notification-actors-line.component.ts

@@ -69,6 +69,6 @@ export class InAppNotificationActorsLineComponent implements OnInit {
       })
       .filter((actor) => actor !== null) as PrincipalLike[];
 
-    this.actors = _.uniqBy(actors, (item) => item.href);
+    this.actors = actors.filter((item, index, self) => index === self.findIndex((other) => other.href === item.href));
   }
 }

frontend/src/app/features/work-packages/components/wp-card-view/services/wp-card-drag-and-drop.service.ts

@@ -133,7 +133,7 @@ export class WorkPackageCardDragAndDropService {
    * Update current order
    */
   private updateOrder(newOrder:string[]) {
-    newOrder = _.uniq(newOrder);
+    newOrder = Array.from(new Set(newOrder));
 
     Promise
       .all(newOrder.map((id) => this

frontend/src/app/features/work-packages/components/wp-fast-table/builders/modes/hierarchy/hierarchy-render-pass.ts

@@ -132,7 +132,12 @@ export class HierarchyRenderPass extends PrimaryRenderPass {
         // Append all new elements
         elements = elements.concat(newElements);
         // Remove duplicates (Regression #29652)
-        this.deferred[parent.id!] = _.uniqBy(elements, (el) => el.id!);
+        const seen = new Set<string>();
+        this.deferred[parent.id!] = elements.filter((el) => {
+          if (seen.has(el.id!)) { return false; }
+          seen.add(el.id!);
+          return true;
+        });
         return true;
       }
       // Otherwise, continue the chain upwards