wip

Author: thykel

app/views/work_packages/show.html.erb

@@ -37,6 +37,7 @@ See COPYRIGHT and LICENSE files for more details.
   <%= auto_discovery_link_tag(:atom,
                               { format: 'atom', key: User.current.rss_key },
                               title: "#{work_package.project} - #{work_package.to_s}") %>
+  <%= tag.link rel: :canonical, href: project_work_package_url(work_package.project_id, work_package.id) %>
 <% end %>
 
 <% content_for :content_body do %>

modules/overviews/app/views/overviews/overviews/show.html.erb

@@ -1,2 +1,6 @@
+<% content_for :header_tags do %>
+  <%= tag.link rel: :canonical, href: project_overview_url(@project.id) %>
+<% end %>
+
 <%= render(Overviews::PageHeaderComponent.new(project: @project, current_user:)) %>
 <%= render(Overviews::ShowComponent.new(project: @project, current_user:)) %>

modules/overviews/spec/requests/overviews/show_spec.rb

@@ -0,0 +1,56 @@
+# frozen_string_literal: true
+
+#-- copyright
+# OpenProject is an open source project management software.
+# Copyright (C) the OpenProject GmbH
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License version 3.
+#
+# OpenProject is a fork of ChiliProject, which is a fork of Redmine. The copyright follows:
+# Copyright (C) 2006-2013 Jean-Philippe Lang
+# Copyright (C) 2010-2013 the ChiliProject Team
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License
+# as published by the Free Software Foundation; either version 2
+# of the License, or (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
+#
+# See COPYRIGHT and LICENSE files for more details.
+#++
+
+require "rails_helper"
+
+RSpec.describe "GET project overview", type: :rails_request do
+  let(:project) { create(:project) }
+
+  current_user { create(:admin) }
+
+  shared_examples "includes canonical link tag" do
+    it "renders a canonical link tag pointing to the numeric-ID project URL" do
+      expect(response).to have_http_status(:ok)
+      expect(response.body).to include(%(<link rel="canonical" href="http://test.host/projects/#{project.id}">))
+    end
+  end
+
+  context "when accessed via the numeric ID" do
+    before { get "/projects/#{project.id}" }
+
+    include_examples "includes canonical link tag"
+  end
+
+  context "when accessed via the string identifier" do
+    before { get "/projects/#{project.identifier}" }
+
+    include_examples "includes canonical link tag"
+  end
+end

spec/requests/work_packages/show_spec.rb

@@ -0,0 +1,61 @@
+# frozen_string_literal: true
+
+#-- copyright
+# OpenProject is an open source project management software.
+# Copyright (C) the OpenProject GmbH
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License version 3.
+#
+# OpenProject is a fork of ChiliProject, which is a fork of Redmine. The copyright follows:
+# Copyright (C) 2006-2013 Jean-Philippe Lang
+# Copyright (C) 2010-2013 the ChiliProject Team
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License
+# as published by the Free Software Foundation; either version 2
+# of the License, or (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
+#
+# See COPYRIGHT and LICENSE files for more details.
+#++
+
+require "rails_helper"
+
+RSpec.describe "GET work package show", type: :rails_request do
+  let(:project) { create(:project) }
+  let(:work_package) { create(:work_package, project:) }
+
+  current_user { create(:user, member_with_permissions: { project => %i[view_work_packages] }) }
+
+  shared_examples "includes canonical link tag" do
+    it "renders a canonical link tag pointing to the project-scoped DB-ID URL" do
+      expect(response).to have_http_status(:ok)
+      expected_path = "/projects/#{project.id}/work_packages/#{work_package.id}"
+      expect(response.body).to include(%(<link rel="canonical" href="http://test.host#{expected_path}">))
+    end
+  end
+
+  context "when accessed via the project-scoped URL" do
+    before { get "/projects/#{project.id}/work_packages/#{work_package.id}/activity" }
+
+    include_examples "includes canonical link tag"
+  end
+
+  context "when accessed via the global URL" do
+    before do
+      get "/work_packages/#{work_package.id}/activity"
+      follow_redirect!
+    end
+
+    include_examples "includes canonical link tag"
+  end
+end