Adds a test for multiple providers and same identifiers

Author: mereghost

modules/wikis/spec/services/wikis/page_link_metadata_service_spec.rb

@@ -34,15 +34,16 @@
 module Wikis
   RSpec.describe PageLinkMetadataService do
     let(:relation) { PageLink.limit(30) }
+    let(:query_double) { instance_double(Adapters::Providers::Internal::Queries::PageInfo) }
+    let(:query_class_double) { class_double(Adapters::Providers::Internal::Queries::PageInfo) }
 
     shared_let(:provider) { create(:internal_wiki_provider) }
     shared_let(:page_links) { create_list(:relation_wiki_page_link, 3, provider:) }
 
     subject(:service) { described_class.new(relation) }
 
     before do
-      query_double = instance_double(Adapters::Providers::Internal::Queries::PageInfo)
-      query_class_double = class_double(Adapters::Providers::Internal::Queries::PageInfo, new: query_double)
+      allow(query_class_double).to receive(:new).with(model: provider).and_return(query_double)
       Adapters::Registry.stub("internal.queries.page_info", query_class_double)
 
       build_inputs.each do |input|
@@ -73,10 +74,52 @@ module Wikis
       expect(page_links.first.title).to eq("Wikis, now with more cheese! Part #{page_links.first.identifier}")
     end
 
+    context "when page links have the same identifier but different providers" do
+      shared_let(:xwiki_provider) { create(:xwiki_provider) }
+      let(:new_page_links) do
+        page_links.map do |pl|
+          create(:relation_wiki_page_link, provider: xwiki_provider, identifier: pl)
+        end
+      end
+
+      before do
+        allow(query_class_double).to receive(:new).with(model: xwiki_provider).and_return(query_double)
+        Adapters::Registry.stub("xwiki.queries.page_info", query_class_double)
+
+        new_page_links.map do |pl|
+          input = Adapters::Input::PageInfo.build(identifier: pl.identifier).value_or(nil)
+          allow(query_double).to receive(:call).with(input).and_return(
+            Success(
+              Adapters::Results::PageInfo.new(title: "Wikis, now with more cheese! Part #{pl.id}",
+                                              identifier: input.identifier,
+                                              href: "totally_valid_url",
+                                              provider: pl.provider)
+            )
+          )
+        end
+      end
+
+      it "maps the titles to the correct page link" do
+        service_result = service.call
+
+        expect(service_result).to be_success
+        relation = service_result.result
+
+        relation.find_each do |page_link|
+          case page_link.provider_id
+          when xwiki_provider.id
+            expect(page_link.title).to eq("Wikis, now with more cheese! Part #{page_link.id}")
+          else
+            expect(page_link.title).to eq("Wikis, now with more cheese! Part #{page_link.identifier}")
+          end
+        end
+      end
+    end
+
     private
 
-    def build_inputs
-      page_links.filter_map { Adapters::Input::PageInfo.build(identifier: it.identifier).value_or(nil) }
+    def build_inputs(relation = page_links)
+      relation.filter_map { Adapters::Input::PageInfo.build(identifier: it.identifier).value_or(nil) }
     end
   end
 end