Skip to content

Commit a39f377

Browse files
committed
[OP-19544] Replace lodash set/dedup in module frontends
The linked-plugin frontends share the global `_` but were outside the frontend/src sweep. Converts `without`/`flatten` in the GitLab module to the same native forms.
1 parent 019408e commit a39f377

5 files changed

Lines changed: 5 additions & 5 deletions

File tree

modules/gitlab_integration/frontend/module/hal/resources/gitlab-issue-resource.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,6 @@ export class GitlabIssueResource extends HalResource {
3838
* Exclude the schema _link from the linkable Resources.
3939
*/
4040
public $linkableKeys():string[] {
41-
return _.without(super.$linkableKeys(), 'schema');
41+
return super.$linkableKeys().filter((key) => key !== 'schema');
4242
}
4343
}

modules/gitlab_integration/frontend/module/hal/resources/gitlab-merge-request-resource.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,6 @@ export class GitlabMergeRequestResource extends HalResource {
3838
* Exclude the schema _link from the linkable Resources.
3939
*/
4040
public $linkableKeys():string[] {
41-
return _.without(super.$linkableKeys(), 'schema');
41+
return super.$linkableKeys().filter((key) => key !== 'schema');
4242
}
4343
}

modules/gitlab_integration/frontend/module/hal/resources/gitlab-user-resource.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,6 @@ export class GitlabUserResource extends HalResource {
3838
* Exclude the schema _link from the linkable Resources.
3939
*/
4040
public $linkableKeys():string[] {
41-
return _.without(super.$linkableKeys(), 'schema');
41+
return super.$linkableKeys().filter((key) => key !== 'schema');
4242
}
4343
}

modules/gitlab_integration/frontend/module/tab-issue/wp-gitlab-issue.service.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,6 @@ export class WorkPackagesGitlabIssueService extends WorkPackageLinkedResourceCac
4646
}
4747

4848
protected sortList(gitlabIssue:HalResource[], attr = 'createdAt'):HalResource[] {
49-
return sortBy(_.flatten(gitlabIssue), attr);
49+
return sortBy(gitlabIssue.flat(), attr);
5050
}
5151
}

modules/gitlab_integration/frontend/module/tab-mrs/wp-gitlab-mrs.service.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,6 @@ export class WorkPackagesGitlabMrsService extends WorkPackageLinkedResourceCache
4646
}
4747

4848
protected sortList(mergeRequests:HalResource[], attr = 'createdAt'):HalResource[] {
49-
return sortBy(_.flatten(mergeRequests), attr);
49+
return sortBy(mergeRequests.flat(), attr);
5050
}
5151
}

0 commit comments

Comments
 (0)