Update SelectPanel variant

Author: mrmir

app/components/workflows/status_matrix_form_component.html.erb

@@ -57,6 +57,14 @@ See COPYRIGHT and LICENSE files for more details.
                 item_id: available_role.id
               )
             end
+            panel.with_footer(show_divider: true) do
+              render(
+                Primer::Beta::Button.new(
+                  scheme: :primary,
+                  data: { action: "click->admin--workflow-role-select#apply" }
+                )
+              ) { t(:button_save) }
+            end
           end
         end
       end

frontend/src/stimulus/controllers/dynamic/admin/workflow-role-select.controller.ts

@@ -45,15 +45,7 @@ export default class WorkflowRoleSelectController extends Controller {
   declare baseUrlValue:string;
   declare currentRoleIdsValue:unknown[];
 
-  connect() {
-    this.element.addEventListener('panelClosed', this.handlePanelClosed);
-  }
-
-  disconnect() {
-    this.element.removeEventListener('panelClosed', this.handlePanelClosed);
-  }
-
-  private handlePanelClosed = () => {
+  apply() {
     const panel = this.element as HTMLElement as SelectPanelElement;
     const selectedIds = panel.items
       .filter((item) => panel.isItemChecked(item))
@@ -69,8 +61,8 @@ export default class WorkflowRoleSelectController extends Controller {
     if (selectedIds.slice().sort().join(',') === this.currentRoleIdsValue.slice().sort().join(',')) return;
 
     this.navigateTo(this.buildUrl(selectedIds as string[]));
-  };
-  
+  }
+
   private buildUrl(roleIds:string[]):string {
     const url = new URL(this.baseUrlValue, window.location.origin);
     roleIds.forEach((id) => url.searchParams.append('role_ids[]', id));

spec/features/workflows/edit_multi_role_spec.rb

@@ -272,7 +272,7 @@
       click_button "2 roles selected"
       find("[data-item-id='#{role.id}']").click
       find("[data-item-id='#{role2.id}']").click
-      page.send_keys :escape
+      click_button "Save"
 
       expect(page).to have_no_text("2 roles selected")
       expect(page).to have_button(role.name)

spec/support/workflows/edit_helpers.rb

@@ -45,7 +45,7 @@ def switch_role_via_panel(from_role, to_role)
       click_button from_role.name
       find("[data-item-id='#{to_role.id}']").click
       find("[data-item-id='#{from_role.id}']").click
-      page.send_keys :escape
+      click_button "Save"
     end
 
     def add_status_via_dialog(status)