remove story and task models

Author: ulferts

modules/backlogs/app/models/story.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 #-- copyright
 # OpenProject is an open source project management software.
 # Copyright (C) the OpenProject GmbH

modules/backlogs/app/models/task.rb

@@ -50,27 +50,27 @@ def render_component(folded: false, active_sprint_ids: nil)
   end
 
   describe "show state (default)" do
-    context "with stories" do
-      let!(:story1) do
-        create(:story,
+    context "with work_packages" do
+      let!(:work_package1) do
+        create(:work_package,
                project:,
                type: type_feature,
                status: default_status,
                priority: default_priority,
                story_points: 5,
                sprint:)
       end
-      let!(:story2) do
-        create(:story,
+      let!(:work_package2) do
+        create(:work_package,
                project:,
                type: type_feature,
                status: default_status,
                priority: default_priority,
                story_points: 3,
                sprint:)
       end
-      let!(:story_with_nil_points) do
-        create(:story,
+      let!(:work_package_with_nil_points) do
+        create(:work_package,
                project:,
                type: type_feature,
                status: default_status,
@@ -85,7 +85,7 @@ def render_component(folded: false, active_sprint_ids: nil)
         expect(page).to have_css("h3", text: "Sprint 1")
       end
 
-      it "shows story count via Primer::Beta::Counter" do
+      it "shows work_package count via Primer::Beta::Counter" do
         render_component
 
         expect(page).to have_css(".Counter", text: "3")
@@ -128,7 +128,7 @@ def render_component(folded: false, active_sprint_ids: nil)
     context "with no stories" do
       let(:stories) { [] }
 
-      it "hides the story count counter" do
+      it "hides the work_package count counter" do
         render_component
 
         expect(page).to have_css(".Counter", text: "0", visible: :hidden)

modules/backlogs/app/services/stories/create_service.rb

@@ -38,23 +38,18 @@
     create(:project,
            enabled_module_names: %w(work_package_tracking backlogs))
   end
-  let(:status) { create(:default_status) }
-  let(:story_type) { create(:type_feature) }
-  let(:task_type) { create(:type_feature) }
 
   describe "showing the story points on the work package show page" do
     let(:story_points) { 42 }
-    let(:story_with_sp) do
-      create(:story,
-             type: story_type,
+    let(:work_package_with_story_points) do
+      create(:work_package,
              author: current_user,
              project:,
-             status:,
              story_points:)
     end
 
     it "is displayed" do
-      wp_page = Pages::FullWorkPackage.new(story_with_sp)
+      wp_page = Pages::FullWorkPackage.new(work_package_with_story_points)
 
       wp_page.visit!
       wp_page.expect_subject

modules/backlogs/app/services/stories/update_service.rb

@@ -29,12 +29,14 @@
 require "spec_helper"
 
 RSpec.describe Burndown do
-  def set_attribute_journalized(story, attribute, value, day)
-    story.reload
-    story.send(attribute, value)
-    story.save!
-    story.journals[-2].update_columns(validity_period: story.journals[-2].created_at...day) if story.journals.count > 1
-    story.journals[-1].update_columns(created_at: day, updated_at: day, validity_period: day..Float::INFINITY)
+  def set_attribute_journalized(work_package, attribute, value, day)
+    work_package.reload
+    work_package.send(attribute, value)
+    work_package.save!
+    if work_package.journals.many?
+      work_package.journals[-2].update_columns(validity_period: work_package.journals[-2].created_at...day)
+    end
+    work_package.journals[-1].update_columns(created_at: day, updated_at: day, validity_period: day..Float::INFINITY)
   end
 
   let(:project) { create(:project) }
@@ -87,29 +89,30 @@ def set_attribute_journalized(story, attribute, value, day)
           sprint.save!
         end
 
-        describe "WITH 1 story assigned to the sprint" do
-          let(:story) do
-            build(:story, subject: "Story 1",
-                          project:,
-                          sprint:,
-                          type: type_feature,
-                          status: issue_open,
-                          priority: issue_priority,
-                          created_at: Time.zone.today - 20.days,
-                          updated_at: Time.zone.today - 20.days)
+        describe "WITH 1 work_package assigned to the sprint" do
+          let(:work_package) do
+            build(:work_package,
+                  subject: "WorkPackage 1",
+                  project:,
+                  sprint:,
+                  type: type_feature,
+                  status: issue_open,
+                  priority: issue_priority,
+                  created_at: Time.zone.today - 20.days,
+                  updated_at: Time.zone.today - 20.days)
           end
 
-          describe "WITH the story having story_point defined on creation" do
+          describe "WITH the work_package having story_point defined on creation" do
             before do
-              story.story_points = 9
-              story.save!
-              story.last_journal.update_columns(created_at: story.created_at, updated_at: story.created_at)
+              work_package.story_points = 9
+              work_package.save!
+              work_package.last_journal.update_columns(created_at: work_package.created_at, updated_at: work_package.created_at)
             end
 
-            describe "WITH the story being closed and opened again within the sprint duration" do
+            describe "WITH the work_package being closed and opened again within the sprint duration" do
               before do
-                set_attribute_journalized story, :status_id=, issue_closed.id, 6.days.ago
-                set_attribute_journalized story, :status_id=, issue_open.id, 3.days.ago
+                set_attribute_journalized work_package, :status_id=, issue_closed.id, 6.days.ago
+                set_attribute_journalized work_package, :status_id=, issue_open.id, 3.days.ago
               end
 
               it { expect(burndown.story_points).to eql [9.0, 0.0, 0.0, 0.0, 9.0, 9.0] }
@@ -124,14 +127,13 @@ def set_attribute_journalized(story, attribute, value, day)
               it { expect(burndown.story_points_ideal).to eql [9.0, 8.0, 7.0, 6.0, 5.0, 4.0, 3.0, 2.0, 1.0, 0.0] }
             end
 
-            describe "WITH the story marked as resolved and consequently 'done'" do
+            describe "WITH the work_package marked as resolved and consequently 'done'" do
               before do
-                set_attribute_journalized story, :status_id=, issue_resolved.id, 6.days.ago
-                set_attribute_journalized story, :status_id=, issue_open.id, 3.days.ago
+                set_attribute_journalized work_package, :status_id=, issue_resolved.id, 6.days.ago
+                set_attribute_journalized work_package, :status_id=, issue_open.id, 3.days.ago
                 project.done_statuses << issue_resolved
               end
 
-              it { expect(story.done?).to be false }
               it { expect(burndown.story_points).to eql [9.0, 0.0, 0.0, 0.0, 9.0, 9.0] }
             end
           end
@@ -142,14 +144,15 @@ def set_attribute_journalized(story, attribute, value, day)
             stories = []
 
             10.times do |i|
-              stories[i] = create(:story, subject: "Story #{i}",
-                                          project:,
-                                          sprint:,
-                                          type: type_feature,
-                                          status: issue_open,
-                                          priority: issue_priority,
-                                          created_at: Time.zone.today - (20 - i).days,
-                                          updated_at: Time.zone.today - (20 - i).days)
+              stories[i] = create(:work_package,
+                                  subject: "WorkPackage #{i}",
+                                  project:,
+                                  sprint:,
+                                  type: type_feature,
+                                  status: issue_open,
+                                  priority: issue_priority,
+                                  created_at: Time.zone.today - (20 - i).days,
+                                  updated_at: Time.zone.today - (20 - i).days)
               stories[i].last_journal.update_columns(created_at: stories[i].created_at,
                                                      updated_at: stories[i].created_at,
                                                      validity_period: stories[i].created_at..Float::INFINITY)
@@ -158,14 +161,14 @@ def set_attribute_journalized(story, attribute, value, day)
             stories
           end
 
-          describe "WITH each story having story points defined at start" do
+          describe "WITH each work_package having story points defined at start" do
             before do
               stories.each do |s|
                 set_attribute_journalized s, :story_points=, 10, sprint.start_date - 3.days
               end
             end
 
-            describe "WITH 5 stories having been reduced to 0 story points, one story per day" do
+            describe "WITH 5 stories having been reduced to 0 story points, one work_package per day" do
               before do
                 5.times do |i|
                   set_attribute_journalized stories[i], :story_points=, nil, sprint.start_date + i.days + 1.hour
@@ -192,10 +195,10 @@ def set_attribute_journalized(story, attribute, value, day)
 
     context "without dates on the sprint" do
       let(:sprint) { create(:sprint, project:, start_date: nil, finish_date: nil) }
-      let(:story) do
-        build(:story,
+      let(:work_package) do
+        build(:work_package,
               :created_in_past,
-              subject: "Story 1",
+              subject: "WorkPackage 1",
               project:,
               sprint:,
               type: type_feature,