remove version_settings.rb

Author: ulferts

modules/backlogs/app/models/version_setting.rb

@@ -29,6 +29,29 @@
 #++
 
 class MigrateVersionsToSprints < ActiveRecord::Migration[8.0]
+  class MigrationVersionSetting < ApplicationRecord
+    self.table_name = "version_settings"
+
+    DISPLAY_LEFT = 2
+    DISPLAY_RIGHT = 3
+  end
+
+  class MigrationWorkPackage < ApplicationRecord
+    self.table_name = "work_packages"
+  end
+
+  class MigrationVersion < ApplicationRecord
+    self.table_name = "versions"
+
+    has_many :work_packages,
+             class_name: "MigrateVersionsToSprints::MigrationWorkPackage",
+             foreign_key: "version_id"
+
+    has_many :version_settings,
+             class_name: "MigrateVersionsToSprints::MigrationVersionSetting",
+             foreign_key: "version_id"
+  end
+
   def up
     return if sprint_versions_with_work_package_ids.none?
 
@@ -50,12 +73,13 @@ def sprint_versions_with_work_package_ids
     # Load versions used as sprints including work package ids associated with the version.
     # Since the same version can be used as a sprint in one project but not in another,
     # the work package ids are filtered by projects where the version is used as a sprint.
-    display_versions = [VersionSetting::DISPLAY_LEFT, VersionSetting::DISPLAY_RIGHT]
-    Version.joins(:version_settings, :work_packages)
-           .where(version_settings: { display: display_versions })
-           .where("work_packages.project_id = version_settings.project_id")
-           .group("versions.id")
-           .select("versions.*, array_agg(DISTINCT work_packages.id) AS wp_ids")
+
+    MigrationVersion
+      .joins(:version_settings, :work_packages)
+      .where(version_settings: { display: [MigrationVersionSetting::DISPLAY_LEFT, MigrationVersionSetting::DISPLAY_RIGHT] })
+      .where("work_packages.project_id = version_settings.project_id")
+      .group("versions.id")
+      .select("versions.*, array_agg(DISTINCT work_packages.id) AS wp_ids")
   end
 
   def create_sprint(version)

modules/backlogs/db/migrate/20260313164539_migrate_versions_to_sprints.rb

@@ -0,0 +1,13 @@
+# frozen_string_literal: true
+
+class RemoveVersionSettings < ActiveRecord::Migration[8.1]
+  def up
+    drop_table :version_settings
+  end
+
+  def down
+    require_relative "tables/version_settings"
+
+    Tables::VersionSettings.table(self)
+  end
+end

modules/backlogs/db/migrate/20260420160236_remove_version_settings.rb

@@ -129,21 +129,15 @@ def self.settings
 
     patches %i[PermittedParams
                WorkPackage
-               Project
-               Version]
+               Project]
 
     patch_with_namespace :BasicData, :SettingSeeder
-    patch_with_namespace :DemoData, :ProjectSeeder
     patch_with_namespace :WorkPackages, :SetAttributesService
     patch_with_namespace :WorkPackages, :BaseContract
     patch_with_namespace :WorkPackages, :UpdateContract
     patch_with_namespace :API, :V3, :WorkPackages, :EagerLoading, :Checksum
 
     config.to_prepare do
-      next if Versions::BaseContract.include?(OpenProject::Backlogs::Patches::Versions::BaseContractPatch)
-
-      Versions::BaseContract.prepend(OpenProject::Backlogs::Patches::Versions::BaseContractPatch)
-
       # Add available settings to the user preferences
       UserPreferences::Schema.merge!(
         "definitions/UserPreferences/properties",

modules/backlogs/lib/open_project/backlogs/engine.rb

@@ -30,6 +30,7 @@
 
 require "spec_helper"
 require Rails.root.join("modules/backlogs/db/migrate/20260313164539_migrate_versions_to_sprints")
+require Rails.root.join("modules/backlogs/db/migrate/20260420160236_remove_version_settings")
 
 RSpec.describe MigrateVersionsToSprints, type: :model do
   subject(:migrate) { ActiveRecord::Migration.suppress_messages { described_class.migrate(:up) } }
@@ -46,11 +47,26 @@
 
   def use_version(as:, version: self.version, project: self.project)
     display = case as
-              when :sprint then VersionSetting::DISPLAY_LEFT
-              when :backlog then VersionSetting::DISPLAY_RIGHT
-              else VersionSetting::DISPLAY_NONE
+              when :sprint then 2
+              when :backlog then 3
+              else 1
               end
-    create(:version_setting, version:, project:, display:)
+
+    ActiveRecord::Migration.suppress_messages do
+      ActiveRecord::Migration.execute(<<~SQL.squish)
+        INSERT INTO version_settings
+          (project_id, version_id, display, created_at, updated_at)
+        VALUES (#{project.id}, #{version.id}, #{display}, NOW(), NOW())
+      SQL
+    end
+  end
+
+  around(:all) do |example|
+    # In this test: RemoveVersionSettings has already run.
+    # In production: RemoveVersionSettings runs after MigrateVersionsToSprints.
+    ActiveRecord::Migration.suppress_messages { RemoveVersionSettings.migrate(:down) }
+    example.run
+    ActiveRecord::Migration.suppress_messages { RemoveVersionSettings.migrate(:up) }
   end
 
   before { use_version(as: version_type) }