Show indeterminate checkboxes in workflows matrix

Author: mrmir

app/controllers/workflows/tabs_controller.rb

@@ -48,7 +48,7 @@ def edit
 
     statuses_for_form
 
-    if @type && @role && @statuses.any?
+    if @type && @roles.any? && @statuses.any?
       workflows_for_form
     end
   end
@@ -100,7 +100,7 @@ def status_dialog
     current_statuses = if params[:status_ids].present?
                          Status.where(id: params[:status_ids].map(&:to_i)).order(:position)
                        elsif @type && @role
-                         statuses_for_role_and_type
+                         statuses_for_roles_and_type
                        else
                          Status.none
                        end
@@ -169,8 +169,8 @@ def statuses_for_form
     @has_status_changes = false
     @statuses = if @type && params[:status_ids].present?
                   statuses_from_params
-                elsif @type && @role
-                  statuses_for_role_and_type
+                elsif @type && @roles.any?
+                  statuses_for_roles_and_type
                 elsif @type
                   @type.statuses
                 else
@@ -180,18 +180,19 @@ def statuses_for_form
 
   def statuses_from_params
     status_ids = params[:status_ids].map(&:to_i)
-    saved_ids = statuses_for_role_and_type.pluck(:id)
+    saved_ids = statuses_for_roles_and_type.pluck(:id)
     @added_status_ids = status_ids - saved_ids
     @has_status_changes = @added_status_ids.any? || (saved_ids - status_ids).any?
     Status.where(id: status_ids).order(:position)
   end
 
-  def statuses_for_role_and_type
-    @type.statuses(role: @role, tab: @tab)
+  def statuses_for_roles_and_type
+    status_ids = @roles.map { |role| @type.statuses(role:, tab: @tab).pluck(:id) }.flatten.uniq
+    Status.where(id: status_ids)
   end
 
   def workflows_for_form
-    workflows = Workflow.where(role_id: @role.id, type_id: @type.id)
+    workflows = Workflow.where(role_id: @roles.map(&:id), type_id: @type.id)
     @workflows = {}
     @workflows["always"] = workflows.select { |w| !w.author && !w.assignee }
     @workflows["author"] = workflows.select(&:author)

app/views/workflows/_form.html.erb

@@ -187,8 +187,9 @@ See COPYRIGHT and LICENSE files for more details.
               <% end %>
             </th>
             <% @statuses.each do |new_status| -%>
-              <% transition_saved = workflows.any? { it.old_status_id == old_status.id && it.new_status_id == new_status.id }
-                 newly_added_status = @added_status_ids.include?(old_status.id) || @added_status_ids.include?(new_status.id) %>
+              <% transition_role_ids = workflows.select { it.old_status_id == old_status.id && it.new_status_id == new_status.id }.map(&:role_id).uniq
+                 newly_added_status = @added_status_ids.include?(old_status.id) || @added_status_ids.include?(new_status.id)
+                 some_roles = !transition_role_ids.empty? && transition_role_ids.size < @roles.size && !newly_added_status %>
               <td>
                 <%=
                   render(Primer::BaseComponent.new(tag: :div, display: :flex, align_items: :center, mx: 1)) do
@@ -198,13 +199,14 @@ See COPYRIGHT and LICENSE files for more details.
                         name: "status[#{old_status.id}][#{new_status.id}]",
                         id: "status_#{old_status.id}_#{new_status.id}", # See BUG https://github.com/primer/view_components/issues/3811
                         value: name,
-                        checked: transition_saved || newly_added_status,
+                        checked: transition_role_ids.any? || newly_added_status,
                         label: t(".matrix_checkbox_label", old_status: old_status.name, new_status: new_status.name),
                         visually_hide_label: true,
                         data: {
                           checkable_target: "checkbox",
                           old_status: old_status.id,
-                          new_status: new_status.id
+                          new_status: new_status.id,
+                          indeterminate: (true if some_roles)
                         }
                       )
                     )

frontend/src/stimulus/controllers/dynamic/admin/workflow-checkbox-state.controller.ts

@@ -83,6 +83,9 @@ export default class WorkflowCheckboxStateController extends Controller<HTMLForm
       this.applyState(statusCheckboxes);
       // Recompute dirty flag: the restored state may differ from DB pristine.
       this.onCheckboxChange();
+    } else {
+      // Apply indeterminate checkboxes only on fresh server rendered content.
+      this.initIndeterminateCheckboxes();
     }
 
     // Use document-level delegation so this works even when the EditComponent
@@ -284,6 +287,12 @@ export default class WorkflowCheckboxStateController extends Controller<HTMLForm
     });
   }
 
+  private initIndeterminateCheckboxes():void {
+    this.element.querySelectorAll<HTMLInputElement>('input[type="checkbox"][data-indeterminate="true"]').forEach((cb) => {
+      cb.indeterminate = true;
+    });
+  }
+
   //
   // Trigger navigation with dirty-state confirmation.
   //