Fix a semantic identifier validation rule#22804
Merged
thykel merged 4 commits intofeature/71654-semantic-converter-3from Apr 21, 2026
Merged
Fix a semantic identifier validation rule#22804thykel merged 4 commits intofeature/71654-semantic-converter-3from
thykel merged 4 commits intofeature/71654-semantic-converter-3from
Conversation
3 tasks
…-3' into fix_identifier_validation_rules
thykel
merged commit 148ebfd
into
feature/71654-semantic-converter-3
10 of 11 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
What are you trying to accomplish?
The current ruleset contains a rule called
starts_with_numberwith checks that the ID does not start with a number.However, this does not rule out underscores -- these are allowed within semantic IDs, but not at the beginning.
Replace the rule with a more focused one.
Screenshots
What approach did you choose and why?
Merge checklist