Do not stub RequestStore in feature spec#22807
Open
oliverguenther wants to merge 2 commits intodevfrom
Open
Conversation
klaustopher
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The way we set up most specs (controller and features) has shadowed a bug in the before_action setup of the 2FA controllers:
login_as(user)is correctly setting up a cookie, but also stubbing the RequestStore, in all specs whether they are features or not.In this case, a before_action was called before
find_current_userwas called. So User.current was not correct, but that only showed outside of specs, as the stub correctly sets it up regardless of execution order.