Skip to content

[59732] List is scrollable even if there is only 1 item#22814

Merged
HDinger merged 2 commits intodevfrom
bug/59732-list-is-scrollable-even-if-there-is-only-1-item
Apr 22, 2026
Merged

[59732] List is scrollable even if there is only 1 item#22814
HDinger merged 2 commits intodevfrom
bug/59732-list-is-scrollable-even-if-there-is-only-1-item

Conversation

@HDinger
Copy link
Copy Markdown
Contributor

@HDinger HDinger commented Apr 17, 2026

Ticket

https://community.openproject.org/wp/59732

What are you trying to accomplish?

  • Bump ngSelect to latest version
  • Avoid unnecessary scrollbars when the additional create option is displayed

What approach did you choose and why?

ngSelect had quite same changes in the meantime. The biggest change was making searchTerm private. Thus we were forced to use the filter method which directly opens the autocompleter. On the global search, that caused some issues as it initally opened the search on page load. That is why I did an ugly workaround and used the private searchTerm there.

@HDinger HDinger added this to the 17.4.x milestone Apr 17, 2026
@HDinger HDinger force-pushed the bug/59732-list-is-scrollable-even-if-there-is-only-1-item branch from 77e806d to 117a403 Compare April 20, 2026 06:56
@HDinger HDinger force-pushed the bug/59732-list-is-scrollable-even-if-there-is-only-1-item branch 4 times, most recently from 48371e8 to 5fb468a Compare April 21, 2026 12:26
@HDinger HDinger force-pushed the bug/59732-list-is-scrollable-even-if-there-is-only-1-item branch from 5fb468a to 3dd3d91 Compare April 22, 2026 06:02
@HDinger HDinger requested a review from oliverguenther April 22, 2026 07:43
@HDinger HDinger merged commit 5f98ee2 into dev Apr 22, 2026
19 of 21 checks passed
@HDinger HDinger deleted the bug/59732-list-is-scrollable-even-if-there-is-only-1-item branch April 22, 2026 08:20
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 22, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Development

Successfully merging this pull request may close these issues.

3 participants