[#72242] Workflows UX improvement: Allow multi-selection of roles in workflow

[mrmir]

Ticket

https://community.openproject.org/wp/72242

What are you trying to accomplish?

• Change the role selector from an ActionMenu to multi-select SelectPanel
• Make all components expect and work with multiple roles instead of just one

What approach did you choose and why?

• Indeterminate checkboxes need some special handling, and the main case is that the form submits the checkboxes based on their default state (checked/unchecked) and the indeterminate state doesn't affect this. This is why there's some more logic in the tabs controller to manage checkbox state per role. Indeterminate checkboxes are read back from the DB to prevent them from being overridden by the default unchecked state

Merge checklist

• Added/updated tests
• Added/updated documentation in Lookbook (patterns, previews, etc)
• Tested major browsers (Chrome, Firefox, Edge, ...)

[mrmir]

Is there an alternate thing I could check here instead of whether or not the background is white or transparent? What I want to be testing is if the indeterminate checkbox is visible, and this needs to be done because if the default state for the checkboxes is switched to "unchecked", all other tests still pass (as indeterminate state is applied correctly), but aren't visible as it's white on white

[oliverguenther]

From the top of my head, I don't have a better idea. Why do we need to check the visuals compared to the indeterminate JS state?

[mrmir]

Because of the case where it can be indeterminate (and technically showing the -), but because the checkbox is unchecked, the background is white, and so it's indistinguishable visually compared to the regular unchecked state

For these cases, the JS state shows correctly that it's indeterminate, so all my specs were passing, but on the screen it looked like blank boxes everywhere 😬

[oliverguenther]

I see. I guess that makes sense to test it like that then?

[mrmir]

Yeah I guess I'll keep it. Let's hope it's not too brittle

[oliverguenther]

I find "Save" confusing here, should probably read more like "Select" or "Update" or "Confirm" ?

[oliverguenther]

I really like the behavior and have not found any issues with it. I believe it will make editing much easier. There is a remark on the Save button in the select panel, but that could also be addressed separately.

[mrmir]

I'll handle the select panel button separately in https://community.openproject.org/wp/74560, where I can also add some basic lookbook docs