Skip to content

Remove legacy Sprint model#22836

Merged
ulferts merged 7 commits intodevfrom
implementation/71254-remove-legacy-sprint-model
Apr 29, 2026
Merged

Remove legacy Sprint model#22836
ulferts merged 7 commits intodevfrom
implementation/71254-remove-legacy-sprint-model

Conversation

@ulferts
Copy link
Copy Markdown
Contributor

@ulferts ulferts commented Apr 20, 2026

Ticket

https://community.openproject.org/wp/71254

What are you trying to accomplish?

  • Remove legacy sprint.rb
  • Move agile/sprint.rb to sprint.rb
  • Move agile/backlog_bucket.rb to backlog_bucket.rb
  • Remove version_settings.rb
    • Migration referencing the model is still usable.
  •  removes backlog.rb
    • The scope inbox_for in it is moved to WorkPackage
  • story.rb, task.rb and prevent_issue_sti.rb removed
  • issue_spec.rb is merged into work_package_spec.rb. Superfluous done? method is removed.
  • Rework work_package_journal_on_burndown_attributes index which should be used by burndown but was using version_id instead of sprint_id

Merge checklist

  • Added/updated tests
  • Added/updated documentation in Lookbook (patterns, previews, etc)
  • Tested major browsers (Chrome, Firefox, Edge, ...)

@myabc myabc force-pushed the code-maintenance/73889-backlogs-module-naming-namespacing branch from 0b1c77e to 031d9f3 Compare April 20, 2026 16:29
@ulferts ulferts force-pushed the implementation/71254-remove-legacy-sprint-model branch 2 times, most recently from 71b32f7 to e559b88 Compare April 20, 2026 16:46
Base automatically changed from code-maintenance/73889-backlogs-module-naming-namespacing to dev April 20, 2026 16:54
@EinLama
Copy link
Copy Markdown
Contributor

EinLama commented Apr 20, 2026

#22706 introduces a patch to the resource link generator that we might be able to remove here, when the sprint model changes its name 👀

@ulferts ulferts force-pushed the implementation/71254-remove-legacy-sprint-model branch 6 times, most recently from 8bab981 to f1817f6 Compare April 27, 2026 12:52
@ulferts ulferts marked this pull request as ready for review April 27, 2026 13:40
@ulferts
Copy link
Copy Markdown
Contributor Author

ulferts commented Apr 27, 2026

The failing spec fails on dev as well.

@ulferts ulferts force-pushed the implementation/71254-remove-legacy-sprint-model branch 3 times, most recently from b6f7920 to c974483 Compare April 28, 2026 14:15
@ulferts
Copy link
Copy Markdown
Contributor Author

ulferts commented Apr 28, 2026

The failing rspec ./modules/team_planner/spec/features/team_planner_context_menu_spec.rb:41 is flickering.

Copy link
Copy Markdown
Contributor

@dombesz dombesz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work👍

attributes:
agile/sprint:
project:
sprint_sharing: "Sprint sharing"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this key being used anywhere?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will be used in the unlikely case that the Backlogs::BacklogSettingsContract adds an error to sprint_sharing

INDEX_NAME = "work_package_journal_on_burndown_attributes"

def up
remove_and_add_burndown_index :sprint_id
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch👏

Comment thread modules/backlogs/spec/migrations/migrate_versions_to_sprints_spec.rb Outdated
@ulferts ulferts force-pushed the implementation/71254-remove-legacy-sprint-model branch from c974483 to ce8577f Compare April 29, 2026 09:29
@ulferts
Copy link
Copy Markdown
Contributor Author

ulferts commented Apr 29, 2026

The failing spec

rspec ./spec/features/work_packages/details/inplace_editor/subject_editor_spec.rb:33

Is a spec known to flicker. The spec is green locally.

@ulferts ulferts merged commit a7ebf8e into dev Apr 29, 2026
16 of 17 checks passed
@ulferts ulferts deleted the implementation/71254-remove-legacy-sprint-model branch April 29, 2026 10:04
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 29, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants