Skip to content

[STC-836] Fixes for the Copy numeric ID feature#23834

Merged
thykel merged 1 commit into
release/17.6from
bug/stc-836-adjustments
Jun 24, 2026
Merged

[STC-836] Fixes for the Copy numeric ID feature#23834
thykel merged 1 commit into
release/17.6from
bug/stc-836-adjustments

Conversation

@thykel

@thykel thykel commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Ticket

https://community.openproject.org/projects/STC/work_packages/STC-836/activity

What are you trying to accomplish?

Address following bugs:

  • In semantic mode, newly created wps trigger 404 when we click on that menu item.
  • In numeric mode, on the WP listing page, this menu item is visible (triggering the same error) but shouldn't be visible at all.
  • We want a different icon for the numeric ID menu item

Screenshots

Screenshot 2026-06-22 at 10 28 19

What approach did you choose and why?

  • Add a copy handler to fix the 404
  • Add a missing actions filtering mechanism to WpContextMenuActions
    • Also, make the pre-existing WpSingleContextMenu mechanism switch to this one, as it's cleaner than setting hidden
  • Change the icon to the recommended one

Merge checklist

  • Added/updated tests
  • Added/updated documentation in Lookbook (patterns, previews, etc)
  • Tested major browsers (Chrome, Firefox, Edge, ...)

@thykel thykel force-pushed the bug/stc-836-adjustments branch 2 times, most recently from dd193a9 to e36d14c Compare June 22, 2026 08:55
@thykel thykel changed the base branch from dev to release/17.6 June 22, 2026 08:55
@thykel thykel marked this pull request as ready for review June 22, 2026 11:27
@thykel thykel requested a review from a team June 22, 2026 11:28
@akabiru

akabiru commented Jun 24, 2026

Copy link
Copy Markdown
Member

@thykel I suggest squashing the last two "fix tests" commits

@thykel thykel force-pushed the bug/stc-836-adjustments branch from 4d5c195 to 31fff57 Compare June 24, 2026 19:23
@github-actions

Copy link
Copy Markdown

Caution

The provided work package version does not match the core version

Details:

Please make sure that:

  • The work package version OR your pull request target branch is correct

@thykel thykel merged commit 4275664 into release/17.6 Jun 24, 2026
15 of 16 checks passed
@thykel thykel deleted the bug/stc-836-adjustments branch June 24, 2026 19:24
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 24, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants