Skip to content

[OP-19592] Security page not showing 2FA settings when reached via "Change password" link from *Account settings* widget#23837

Merged
HDinger merged 1 commit into
release/17.6from
bug/op-19592-security-page-not-showing-2fa-settings-when-reached-via-change-password-link-from-account-settings-widget
Jun 23, 2026
Merged

[OP-19592] Security page not showing 2FA settings when reached via "Change password" link from *Account settings* widget#23837
HDinger merged 1 commit into
release/17.6from
bug/op-19592-security-page-not-showing-2fa-settings-when-reached-via-change-password-link-from-account-settings-widget

Conversation

@HDinger

@HDinger HDinger commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Ticket

https://community.openproject.org/wp/OP-19592

What are you trying to accomplish?

Update "change password" link to new security page

@HDinger HDinger added this to the 17.6.x milestone Jun 22, 2026
@github-actions

Copy link
Copy Markdown

Warning

Flaky specs

  • rspec ./modules/backlogs/spec/features/backlogs/create_spec.rb[1:3:2]
🤖 Ask Copilot to investigate

Copy the prompt below into a new comment on this PR to delegate the investigation to GitHub Copilot. It will look into the flakiness and open a separate pull request with you as reviewer.

@copilot The following spec(s) are flaky in CI (first seen on PR #23837, linked for reference only):

- `rspec ./modules/backlogs/spec/features/backlogs/create_spec.rb[1:3:2]`

Treat this as a standalone task, unrelated to PR #23837. Create a new branch from origin/dev and open a new pull request targeting dev — do not stack it on PR #23837 or reuse that branch.

Follow the playbook in docs/development/testing/handling-flaky-tests/README.md to find the root cause and fix the underlying race — do not skip, delete, or weaken the spec to make it pass; disabling is a last resort per the playbook, and only with a bug ticket. Verify the fix by running the spec(s) repeatedly (e.g. `script/bulk_run_rspec --run-count 10`).

If you cannot reproduce the flake or are not confident in a fix after reasonable investigation, do not fabricate a change or skip the spec to force CI green. Instead, leave the pull request in draft and document what you tried, the suspected cause, and any leads in its description, then assign @HDinger to take over.

Once the fix is verified, title the PR after the spec(s) it fixes, and use the PR description to explain the root cause, how the change resolves it, and the before/after results. Label the PR `flaky-spec`, assign @HDinger, and request a review from @HDinger.
On every commit, set @HDinger as the sole co-author with a `Co-authored-by:` trailer (use their GitHub no-reply email so it links to their account), so it is traceable who dispatched the fix.

@HDinger HDinger merged commit 401695f into release/17.6 Jun 23, 2026
16 checks passed
@HDinger HDinger deleted the bug/op-19592-security-page-not-showing-2fa-settings-when-reached-via-change-password-link-from-account-settings-widget branch June 23, 2026 08:36
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 23, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Development

Successfully merging this pull request may close these issues.

2 participants