refactor: TodoDetail 시트 Store 스코프 정리

Author: opficdev

Application/DevLogPresentation/Sources/Home/Detail/TodoDetailFeature.swift

@@ -27,15 +27,33 @@ struct TodoDetailFeature {
     struct SheetState: Equatable {
         var destination: Destination
 
+        var todoDetail: TodoDetailFeature.State? {
+            get {
+                guard case .todo(let state) = destination else { return nil }
+                return state
+            }
+            set {
+                guard let newValue else { return }
+                destination = .todo(newValue)
+            }
+        }
+
         enum Destination: Equatable {
             case info
-            case todo(TodoIdItem)
+            case todo(TodoDetailFeature.State)
         }
 
         static let info = Self(destination: .info)
 
         static func todo(_ todoId: TodoIdItem) -> Self {
-            Self(destination: .todo(todoId))
+            Self(
+                destination: .todo(
+                    TodoDetailFeature.State(
+                        todoId: todoId.id,
+                        showEditButton: false
+                    )
+                )
+            )
         }
     }
 
@@ -62,8 +80,10 @@ struct TodoDetailFeature {
         case setReferenceItems([Int: TodoReferenceItem])
         case setLoading(Bool)
 
-        enum Sheet: Equatable {
+        @CasePathable
+        enum Sheet {
             case tapCloseButton
+            case todo(TodoDetailFeature.Action)
         }
     }
 
@@ -107,6 +127,21 @@ struct TodoDetailFeature {
             return .none
         }
         .ifLet(\.$alert, action: \.alert)
+        .ifLet(\.$sheet, action: \.sheet) {
+            TodoDetailSheetFeature()
+        }
+    }
+}
+
+private struct TodoDetailSheetFeature: Reducer {
+    typealias State = TodoDetailFeature.SheetState
+    typealias Action = TodoDetailFeature.Action.Sheet
+
+    var body: some ReducerOf<Self> {
+        EmptyReducer()
+        .ifLet(\.todoDetail, action: \.todo) {
+            TodoDetailFeature()
+        }
     }
 }
 

Application/DevLogPresentation/Sources/Home/Detail/TodoDetailView.swift

@@ -118,20 +118,15 @@ struct TodoDetailView: View {
                     sheetStore.send(.tapCloseButton)
                 }
             }
-        case .todo(let item):
+        case .todo:
             NavigationStack {
-                TodoDetailView(store: Store(
-                    initialState: TodoDetailFeature.State(todoId: item.id, showEditButton: false)
-                ) {
-                    TodoDetailFeature()
-                } withDependencies: {
-                    $0.fetchTodoByIdUseCase = container.resolve(FetchTodoByIdUseCase.self)
-                    $0.fetchReferenceItemsUseCase = container.resolve(FetchReferenceItemsUseCase.self)
-                })
-                .toolbar {
-                    ToolbarLeadingButton {
-                        sheetStore.send(.tapCloseButton)
-                    }
+                if let todoStore = sheetStore.scope(state: \.todoDetail, action: \.todo) {
+                    TodoDetailView(store: todoStore)
+                        .toolbar {
+                            ToolbarLeadingButton {
+                                sheetStore.send(.tapCloseButton)
+                            }
+                        }
                 }
             }
             .background(Color(.systemGroupedBackground))

Application/DevLogPresentation/Tests/Home/TodoDetailFeatureTests.swift

@@ -140,9 +140,10 @@ struct TodoDetailFeatureTests {
     }
 
     @Test("시트와 편집 화면 상태를 액션에 맞게 변경한다")
-    func 시트와_편집_화면_상태를_액션에_맞게_변경한다() {
+    func 시트와_편집_화면_상태를_액션에_맞게_변경한다() async {
+        let fetchSpy = FetchTodoByIdUseCaseSpy(todo: makeTodo(id: "todo-2"))
         let adapter = TodoDetailStoreTestAdapter(
-            fetchUseCase: FetchTodoByIdUseCaseSpy(todo: makeTodo()),
+            fetchUseCase: fetchSpy,
             referenceUseCase: FetchReferenceItemsUseCaseSpy(),
             todoId: "todo-1",
             showEditButton: false
@@ -157,7 +158,16 @@ struct TodoDetailFeatureTests {
 
         adapter.setSheet(.todo(TodoIdItem(id: "todo-2")))
 
-        #expect(adapter.sheet == .todo(TodoIdItem(id: "todo-2")))
+        #expect(adapter.sheet?.todoDetail?.todoId == "todo-2")
+        #expect(adapter.sheet?.todoDetail?.showEditButton == false)
+
+        adapter.onSheetTodoAppear()
+
+        await waitUntil {
+            adapter.sheet?.todoDetail?.todo?.id == "todo-2"
+        }
+
+        #expect(fetchSpy.todoIds == ["todo-2"])
 
         adapter.dismissSheet()
         adapter.dismissFullScreenCover()
@@ -179,6 +189,7 @@ private protocol TodoDetailTestAdapter {
     var fullScreenCover: TodoDetailFeature.FullScreenCoverState? { get }
 
     func onAppear()
+    func onSheetTodoAppear()
     func setSheet(_ sheet: TodoDetailFeature.SheetState?)
     func dismissSheet()
     func setFullScreenCover(_ cover: TodoDetailFeature.FullScreenCoverState?)
@@ -246,6 +257,8 @@ private struct TodoDetailStoreTestAdapter: TodoDetailTestAdapter {
         store.send(.onAppear)
     }
 
+    func onSheetTodoAppear() { store.send(.sheet(.presented(.todo(.onAppear)))) }
+
     func setSheet(_ sheet: TodoDetailFeature.SheetState?) {
         store.send(.setSheet(sheet))
     }