refactor: 불필요 쿼리 및 페이지네이션 제거

Author: opficdev

Firebase/functions/src/todo/cleanup.ts

@@ -81,21 +81,12 @@ export const cleanupSoftDeletedTodos = onSchedule({
     },
     async () => {
         try {
-            let lastDocument:
-                FirebaseFirestore.QueryDocumentSnapshot<FirebaseFirestore.DocumentData> | undefined;
-
             while (true) {
-                let query = admin.firestore()
+                const snapshot = await admin.firestore()
                     .collectionGroup("todoLists")
                     .where("isDeleted", "==", true)
-                    .orderBy(admin.firestore.FieldPath.documentId())
-                    .limit(QUERY_BATCH_SIZE);
-
-                if (lastDocument) {
-                    query = query.startAfter(lastDocument);
-                }
-
-                const snapshot = await query.get();
+                    .limit(QUERY_BATCH_SIZE)
+                    .get();
                 if (snapshot.empty) { return; }
 
                 const batch = admin.firestore().batch();
@@ -105,7 +96,6 @@ export const cleanupSoftDeletedTodos = onSchedule({
                 await batch.commit();
 
                 if (snapshot.size < QUERY_BATCH_SIZE) { return; }
-                lastDocument = snapshot.docs[snapshot.docs.length - 1];
             }
         } catch (error) {
             logger.error(
@@ -114,7 +104,6 @@ export const cleanupSoftDeletedTodos = onSchedule({
                 {
                     collectionGroup: "todoLists",
                     filter: "isDeleted == true",
-                    orderBy: "__name__",
                     queryBatchSize: QUERY_BATCH_SIZE
                 }
             );