refactor: RootFeature BindingAction 적용

Author: opficdev

Application/DevLogPresentation/Sources/Root/RootFeature.swift

@@ -26,6 +26,7 @@ struct RootFeature {
         var isNetworkConnected = true
         var signIn: Bool?
         var theme: SystemTheme = .automatic
+        var selectedMainTab = MainTab.home
         var isObservingNetworkConnectivity = false
         var isObservingSession = false
         var isObservingTheme = false
@@ -37,15 +38,17 @@ struct RootFeature {
         var id: String { todoId }
     }
 
-    enum Action: Equatable {
+    enum Action: BindableAction, Equatable {
         case alert(PresentationAction<Never>)
+        case binding(BindingAction<State>)
         case sheet(PresentationAction<Sheet>)
         case view(ViewAction)
         case store(StoreAction)
 
         enum ViewAction: Equatable {
             case onAppear
             case presentTodoDetail(String)
+            case openWidgetRoute(MainTab)
         }
 
         enum Sheet: Equatable {
@@ -66,10 +69,13 @@ struct RootFeature {
     @Dependency(\.setApplicationBadgeCount) var setApplicationBadgeCount
 
     var body: some ReducerOf<Self> {
+        BindingReducer()
         Reduce { state, action in
             switch action {
             case .alert:
                 break
+            case .binding:
+                break
             case .sheet(.dismiss), .sheet(.presented(.tapCloseButton)):
                 state.sheet = nil
             case .sheet:
@@ -95,6 +101,9 @@ struct RootFeature {
                 return effect
             case .view(.presentTodoDetail(let todoId)):
                 state.sheet = .init(todoId: todoId)
+            case .view(.openWidgetRoute(let mainTab)):
+                guard state.signIn == true else { break }
+                state.selectedMainTab = mainTab
             case .store(.networkStatusChanged(let isConnected)):
                 let wasConnected = state.isNetworkConnected
                 state.isNetworkConnected = isConnected
@@ -105,7 +114,9 @@ struct RootFeature {
                 state.theme = theme
             case .store(.didLogined(let result)):
                 state.signIn = result
-                if !result {
+                if result {
+                    state.selectedMainTab = .home
+                } else {
                     return trackLoginScreenEffect()
                 }
             }

Application/DevLogPresentation/Sources/Root/RootView.swift

@@ -14,7 +14,6 @@ import DevLogDomain
 public struct RootView: View {
     @Environment(\.diContainer) var container: DIContainer
     @State private var store: StoreOf<RootFeature>
-    @State private var selectedMainTab = MainTab.home
     private let widgetURLTab: (URL) -> MainTab?
     private let windowEvent: TodoEditorWindowEvent
     private let pushNotificationTodoIdPublisher: AnyPublisher<String, Never>
@@ -52,7 +51,7 @@ public struct RootView: View {
                     MainView(
                         container: container,
                         windowEvent: windowEvent,
-                        selectedTab: $selectedMainTab
+                        selectedTab: $store.selectedMainTab
                     )
                 } else {
                     LoginView(signInUseCase: container.resolve(SignInUseCase.self))
@@ -61,22 +60,9 @@ public struct RootView: View {
         }
         .preferredColorScheme(store.theme.colorScheme)
         .onAppear { store.send(.view(.onAppear)) }
-        .onChange(of: store.signIn) { _, value in
-            guard let value else { return }
-            if value {
-                selectedMainTab = .home
-            }
-        }
         .onOpenURL { url in
             guard let mainTab = widgetURLTab(url) else { return }
-            switch store.signIn {
-            case .some(false):
-                break
-            case .some(true):
-                selectedMainTab = mainTab
-            case .none:
-                break
-            }
+            store.send(.view(.openWidgetRoute(mainTab)))
         }
         .alert($store.scope(state: \.alert, action: \.alert))
         .sheet(item: $store.scope(state: \.sheet, action: \.sheet)) { sheetStore in

Application/DevLogPresentation/Tests/Root/RootFeatureTestSupport.swift

@@ -24,6 +24,8 @@ protocol RootStateDriving {
     func didLogined(_ signIn: Bool) async
     func presentTodoDetail(_ todoId: String) async
     func dismissSheet() async
+    func selectMainTab(_ tab: MainTab) async
+    func openWidgetRoute(_ tab: MainTab) async
 }
 
 struct RootStateSnapshot: Equatable {
@@ -32,6 +34,7 @@ struct RootStateSnapshot: Equatable {
     let isNetworkConnected: Bool
     let signIn: Bool?
     let theme: SystemTheme
+    let selectedMainTab: MainTab
 }
 
 @MainActor
@@ -44,7 +47,8 @@ struct RootStoreTestAdapter: RootStateDriving {
             alertMessage: store.state.alert?.message.map { String(state: $0) },
             isNetworkConnected: store.state.isNetworkConnected,
             signIn: store.state.signIn,
-            theme: store.state.theme
+            theme: store.state.theme,
+            selectedMainTab: store.state.selectedMainTab
         )
     }
     var sheetTodoId: String? { store.state.sheet?.todoId }
@@ -107,6 +111,14 @@ struct RootStoreTestAdapter: RootStateDriving {
         await store.send(.sheet(.dismiss))
     }
 
+    func selectMainTab(_ tab: MainTab) async {
+        await store.send(.binding(.set(\.selectedMainTab, tab)))
+    }
+
+    func openWidgetRoute(_ tab: MainTab) async {
+        await store.send(.view(.openWidgetRoute(tab)))
+    }
+
     private func drainReceivedActions() async {
         for _ in 0..<8 {
             await store.skipReceivedActions(strict: false)
@@ -125,7 +137,8 @@ func verifyNetworkDisconnectedAlert(adapter: some RootStateDriving) async {
                 alertMessage: String(localized: "root_network_disconnected_message"),
                 isNetworkConnected: false,
                 signIn: nil,
-                theme: .automatic
+                theme: .automatic,
+                selectedMainTab: .home
             )
     )
 }
@@ -142,7 +155,8 @@ func verifySetAlert(adapter: some RootStateDriving) async {
                 alertMessage: nil,
                 isNetworkConnected: false,
                 signIn: nil,
-                theme: .automatic
+                theme: .automatic,
+                selectedMainTab: .home
             )
     )
 }
@@ -153,6 +167,7 @@ func verifyThemeUpdate(adapter: some RootStateDriving) async {
 
     #expect(adapter.snapshot.theme == .dark)
     #expect(adapter.snapshot.alertTitle == nil)
+    #expect(adapter.snapshot.selectedMainTab == .home)
 }
 
 @MainActor
@@ -166,6 +181,7 @@ func verifyDidLoginedFalse(
     }
 
     #expect(adapter.snapshot.signIn == false)
+    #expect(adapter.snapshot.selectedMainTab == .home)
     #expect(trackAnalyticsEventUseCaseSpy.screenNames == ["login"])
 }
 
@@ -174,9 +190,11 @@ func verifyDidLoginedTrue(
     adapter: some RootStateDriving,
     trackAnalyticsEventUseCaseSpy: RootTrackAnalyticsEventUseCaseSpy
 ) async {
+    await adapter.selectMainTab(.today)
     await adapter.didLogined(true)
 
     #expect(adapter.snapshot.signIn == true)
+    #expect(adapter.snapshot.selectedMainTab == .home)
     #expect(trackAnalyticsEventUseCaseSpy.screenNames.isEmpty)
 }
 
@@ -198,7 +216,8 @@ func verifyObservedInitialValues(adapter: some RootStateDriving) async {
                 alertMessage: String(localized: "root_network_disconnected_message"),
                 isNetworkConnected: false,
                 signIn: false,
-                theme: .dark
+                theme: .dark,
+                selectedMainTab: .home
             )
     )
 }
@@ -212,6 +231,16 @@ func verifyTodoDetailSheetPresentation(adapter: some RootStateDriving) async {
     #expect(adapter.sheetTodoId == nil)
 }
 
+@MainActor
+func verifyWidgetRouteOpensWhenSignedIn(adapter: some RootStateDriving) async {
+    await adapter.openWidgetRoute(.today)
+    #expect(adapter.snapshot.selectedMainTab == .home)
+
+    await adapter.didLogined(true)
+    await adapter.openWidgetRoute(.today)
+    #expect(adapter.snapshot.selectedMainTab == .today)
+}
+
 final class ObserveAuthSessionUseCaseSpy: ObserveAuthSessionUseCase {
     let subject: CurrentValueSubject<Bool, Never>
     private(set) var observeCallCount = 0

Application/DevLogPresentation/Tests/Root/RootFeatureTests.swift

@@ -39,8 +39,8 @@ struct RootFeatureTests {
         await verifyDidLoginedFalse(adapter: adapter, trackAnalyticsEventUseCaseSpy: trackSpy)
     }
 
-    @Test("RootFeature didLogined(true)는 기존 Root 상태관리처럼 signIn 상태만 true로 갱신한다")
-    func RootFeature_didLogined_true는_기존_Root_상태관리처럼_signIn_상태만_true로_갱신한다() async {
+    @Test("RootFeature didLogined(true)는 기존 Root 상태관리처럼 signIn 상태를 true로 갱신하고 selectedMainTab을 home으로 되돌린다")
+    func RootFeature_didLogined_true는_기존_Root_상태관리처럼_signIn_상태를_true로_갱신하고_selectedMainTab을_home으로_되돌린다() async {
         let trackSpy = RootTrackAnalyticsEventUseCaseSpy()
         let adapter = RootStoreTestAdapter(trackAnalyticsEventUseCase: trackSpy)
 
@@ -97,4 +97,11 @@ struct RootFeatureTests {
 
         await verifyTodoDetailSheetPresentation(adapter: adapter)
     }
+
+    @Test("RootFeature는 로그인된 경우에만 widget route로 selectedMainTab을 변경한다")
+    func RootFeature는_로그인된_경우에만_widget_route로_selectedMainTab을_변경한다() async {
+        let adapter = RootStoreTestAdapter()
+
+        await verifyWidgetRouteOpensWhenSignedIn(adapter: adapter)
+    }
 }