Skip to content

Commit 6ce0574

Browse files
authored
[#583] 푸시 알림 detail 섹션의 배경색을 변경한다 (#584)
* chore: drawio 파일 추적 제거 * refactor: 불필요 모디파이어 제거 * ui: 푸시 알림을 선택하기 전 뷰의 배경색 수정 * docs: 앱스토어 이미지 추가 * refactor: AlertTitle 사용
1 parent 2e40f92 commit 6ce0574

9 files changed

Lines changed: 21 additions & 849 deletions

File tree

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -48,4 +48,5 @@ fastlane/logs/
4848
Tuist/.build/
4949

5050
# drawio
51+
*.drawio
5152
*.drawio.bkp

Application/DevLogPresentation/Sources/Main/MainView.swift

Lines changed: 19 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -135,23 +135,8 @@ struct MainView: View {
135135
)
136136
.navigationSplitViewColumnWidth(min: 350, ideal: 450, max: nil)
137137
} detail: {
138-
Group {
139-
if let todoId = pushNotificationListViewCoordinator.todoIdToPresent?.id {
140-
TodoDetailView(
141-
viewModel: pushNotificationListViewCoordinator.makeTodoDetailViewModel(
142-
todoId: todoId
143-
)
144-
)
145-
.id(todoId)
146-
} else {
147-
ContentUnavailableView(
148-
String(localized: "push_notifications_select_detail"),
149-
systemImage: "bell.badge"
150-
)
151-
}
152-
}
138+
notificationRegularDetailView
153139
}
154-
.background(Color(.systemGroupedBackground).ignoresSafeArea())
155140
case .profile:
156141
NavigationSplitView {
157142
mainSidebar
@@ -322,6 +307,24 @@ struct MainView: View {
322307
)
323308
}
324309

310+
@ViewBuilder
311+
private var notificationRegularDetailView: some View {
312+
if let todoId = pushNotificationListViewCoordinator.todoIdToPresent?.id {
313+
TodoDetailView(
314+
viewModel: pushNotificationListViewCoordinator.makeTodoDetailViewModel(
315+
todoId: todoId
316+
)
317+
)
318+
.id(todoId)
319+
} else {
320+
ContentUnavailableView(
321+
String(localized: "push_notifications_select_detail"),
322+
systemImage: "bell.badge"
323+
)
324+
.background(Color(.systemGroupedBackground).ignoresSafeArea())
325+
}
326+
}
327+
325328
private var profileView: some View {
326329
ProfileView(
327330
coordinator: profileViewCoordinator,

Application/DevLogPresentation/Sources/PushNotification/PushNotificationListView.swift

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,9 +36,8 @@ struct PushNotificationListView: View {
3636
.navigationTitle(String(localized: "nav_push_notifications"))
3737
.listStyle(.plain)
3838
}
39-
.background(Color(.systemGroupedBackground).ignoresSafeArea())
4039
.alert(
41-
"",
40+
viewModel.state.alertTitle,
4241
isPresented: Binding(
4342
get: { viewModel.state.showAlert },
4443
set: { viewModel.send(.setAlert(isPresented: $0)) }

docs/AppStore_iPad_Hitmap.png

279 KB
Loading

docs/AppStore_iPad_Home.png

323 KB
Loading

docs/AppStore_iPad_Markdown.png

451 KB
Loading
256 KB
Loading

docs/AppStore_iPad_Today.png

274 KB
Loading

docs/DevLog.drawio

Lines changed: 0 additions & 831 deletions
This file was deleted.

0 commit comments

Comments
 (0)