refactor: AuthService 프로토콜의 FirebaseAuth 에러 판별 제거

Author: opficdev

Application/DevLogData/Sources/Protocol/AuthService.swift

@@ -21,5 +21,4 @@ public protocol AuthService {
     func getProviderID() async throws -> String?
     func deleteCurrentUser() async throws
     func clearCurrentSession() async throws
-    func isCredentialAlreadyInUseError(_ error: Error) -> Bool
 }

Application/DevLogData/Sources/Repository/AuthDataRepositoryImpl.swift

@@ -94,10 +94,6 @@ private extension AuthDataRepositoryImpl {
             }
         }
 
-        if authService.isCredentialAlreadyInUseError(error) {
-            return AuthError.linkCredentialAlreadyInUse
-        }
-
         return error
     }
 }

Application/DevLogInfra/Sources/Extension/FirebaseAuthUser+.swift

@@ -26,3 +26,14 @@ extension FirebaseAuth.User {
         )
     }
 }
+
+extension Error {
+    var isFirebaseCredentialAlreadyInUse: Bool {
+        let nsError = self as NSError
+        guard nsError.domain == AuthErrorDomain,
+              let authErrorCode = AuthErrorCode(rawValue: nsError.code) else {
+            return false
+        }
+        return authErrorCode == .credentialAlreadyInUse
+    }
+}

Application/DevLogInfra/Sources/Service/AuthServiceImpl.swift

@@ -134,12 +134,4 @@ final class AuthServiceImpl: AuthService {
         }
     }
 
-    func isCredentialAlreadyInUseError(_ error: Error) -> Bool {
-        let nsError = error as NSError
-        guard nsError.domain == AuthErrorDomain,
-              let authErrorCode = AuthErrorCode(rawValue: nsError.code) else {
-            return false
-        }
-        return authErrorCode == .credentialAlreadyInUse
-    }
 }

Application/DevLogInfra/Sources/Service/SocialLogin/AppleAuthenticationServiceImpl.swift

@@ -14,6 +14,7 @@ import FirebaseMessaging
 import Foundation
 import DevLogCore
 import DevLogData
+import DevLogDomain
 
 final class AppleAuthenticationServiceImpl: AuthenticationService {
     private enum FunctionName: String {
@@ -159,6 +160,9 @@ final class AppleAuthenticationServiceImpl: AuthenticationService {
             try await user?.link(with: appleCredential)
         } catch {
             logger.error("Failed to link Apple account", error: error)
+            if error.isFirebaseCredentialAlreadyInUse {
+                throw AuthError.linkCredentialAlreadyInUse
+            }
             throw error
         }
     }

Application/DevLogInfra/Sources/Service/SocialLogin/GithubAuthenticationServiceImpl.swift

@@ -14,6 +14,7 @@ import FirebaseMessaging
 import Nexa
 import DevLogCore
 import DevLogData
+import DevLogDomain
 
 final class GithubAuthenticationServiceImpl: NSObject, AuthenticationService {
     private enum FunctionName: String {
@@ -143,6 +144,9 @@ final class GithubAuthenticationServiceImpl: NSObject, AuthenticationService {
             logger.info("Successfully linked GitHub account")
         } catch {
             logger.error("Failed to link GitHub account", error: error)
+            if error.isFirebaseCredentialAlreadyInUse {
+                throw AuthError.linkCredentialAlreadyInUse
+            }
             throw error
         }
     }

Application/DevLogInfra/Sources/Service/SocialLogin/GoogleAuthenticationServiceImpl.swift

@@ -12,6 +12,7 @@ import Foundation
 import GoogleSignIn
 import DevLogCore
 import DevLogData
+import DevLogDomain
 
 final class GoogleAuthenticationServiceImpl: AuthenticationService {
     private let store = Firestore.firestore()
@@ -123,6 +124,9 @@ final class GoogleAuthenticationServiceImpl: AuthenticationService {
             try await user?.link(with: credential)
         } catch {
             logger.error("Failed to link Google account", error: error)
+            if error.isFirebaseCredentialAlreadyInUse {
+                throw AuthError.linkCredentialAlreadyInUse
+            }
             throw error
         }
     }