refactor: isPinned 플래그에서 옵셔널 제거

Author: opficdev

Application/DevLogCore/Sources/TodoQuery.swift

@@ -35,7 +35,7 @@ public struct TodoQuery: Equatable, Sendable {
 
     public var categoryId: String?
     public var keyword: String?
-    public var isPinned: Bool?
+    public var isPinned: Bool
     public var completionFilter: CompletionFilter
     public var dueDateFilter: DueDateFilter
     public var sortDateFrom: Date?
@@ -49,7 +49,7 @@ public struct TodoQuery: Equatable, Sendable {
     public init(
         categoryId: String? = nil,
         keyword: String? = nil,
-        isPinned: Bool? = nil,
+        isPinned: Bool = false,
         completionFilter: CompletionFilter = .all,
         dueDateFilter: DueDateFilter = .all,
         sortDateFrom: Date? = nil,

Application/DevLogInfra/Sources/Service/TodoServiceImpl.swift

@@ -35,7 +35,7 @@ final class TodoServiceImpl: TodoService {
             "sortOrder=\(query.sortOrder == .latest ? "latest" : "oldest")",
             query.keyword != nil ? "keywordLength=\(trimmedKeyword.count)" : nil,
             query.categoryId != nil ? "category=\(query.categoryId!)" : nil,
-            query.isPinned != nil ? "pinned=\(query.isPinned!)" : nil,
+            query.isPinned ? "pinned=true" : nil,
             query.completionFilter.isCompletedValue != nil
                 ? "completed=\(query.completionFilter.isCompletedValue!)"
                 : nil,
@@ -58,8 +58,8 @@ final class TodoServiceImpl: TodoService {
             )
         }
 
-        if let isPinned = query.isPinned {
-            firestoreQuery = firestoreQuery.whereField("isPinned", isEqualTo: isPinned)
+        if query.isPinned {
+            firestoreQuery = firestoreQuery.whereField("isPinned", isEqualTo: true)
         }
 
         if let isCompleted = query.completionFilter.isCompletedValue {

Application/DevLogPresentation/Sources/Home/List/TodoListFeature.swift

@@ -43,16 +43,11 @@ struct TodoListFeature {
             var count = 0
             if query.sortTarget != .createdAt { count += 1 }
             if query.sortOrder != .latest { count += 1 }
-            if query.isPinned != nil { count += 1 }
+            if query.isPinned { count += 1 }
             if query.completionFilter != .all { count += 1 }
             return count
         }
 
-        var isPinnedOnly: Bool {
-            get { query.isPinned == true }
-            set { query.isPinned = newValue ? true : nil }
-        }
-
         static func == (lhs: Self, rhs: Self) -> Bool {
             lhs.category == rhs.category &&
             lhs.todos == rhs.todos &&
@@ -202,7 +197,7 @@ private extension TodoListFeature {
             state.searchResults = []
             state.showAllSearchResults = false
             return cancelSearchEffect()
-        case .binding(\.query.sortTarget), .binding(\.query.sortOrder), .binding(\.isPinnedOnly),
+        case .binding(\.query.sortTarget), .binding(\.query.sortOrder), .binding(\.query.isPinned),
             .binding(\.query.completionFilter):
             state.nextCursor = nil
             return fetchEffect(query: state.query, cursor: nil)

Application/DevLogPresentation/Sources/Home/List/TodoListView.swift

@@ -379,7 +379,7 @@ struct TodoListView: View {
 
     private var filterMenu: some View {
         Menu {
-            Toggle(isOn: $store.isPinnedOnly) {
+            Toggle(isOn: $store.query.isPinned) {
                 Text(String(localized: "todo_pinned"))
             }
 
@@ -391,7 +391,7 @@ struct TodoListView: View {
                 Text(String(localized: "todo_list_completion_status"))
             }
         } label: {
-            let condition = store.state.query.isPinned == true || store.state.query.completionFilter != .all
+            let condition = store.state.query.isPinned || store.state.query.completionFilter != .all
             HStack {
                 Text(String(localized: "todo_list_filter_options"))
                 Image(systemName: "chevron.down")

Application/DevLogPresentation/Tests/Home/TodoListFeatureTestDoubles.swift

@@ -74,7 +74,7 @@ final class TodoListStoreTestAdapter {
     }
 
     func togglePinnedOnly() async {
-        await store.send(.binding(.set(\.isPinnedOnly, !store.state.isPinnedOnly)))
+        await store.send(.binding(.set(\.query.isPinned, !store.state.query.isPinned)))
         await drainReceivedActions()
     }