refactor: compactedAt에 대한 쿼리를 제거하고 해당 필드의 존재 유무로 압축 여부를 결정하도록 개선

Author: opficdev

Firebase/firestore.index.json

@@ -1,23 +1,5 @@
 {
   "indexes": [
-    {
-      "collectionGroup": "todoLists",
-      "queryScope": "COLLECTION_GROUP",
-      "fields": [
-        {
-          "fieldPath": "compactedAt",
-          "order": "ASCENDING"
-        },
-        {
-          "fieldPath": "deletedAt",
-          "order": "ASCENDING"
-        },
-        {
-          "fieldPath": "__name__",
-          "order": "ASCENDING"
-        }
-      ]
-    },
     {
       "collectionGroup": "todoLists",
       "queryScope": "COLLECTION_GROUP",
@@ -606,28 +588,6 @@
     }
   ],
   "fieldOverrides": [
-    {
-      "collectionGroup": "todoLists",
-      "fieldPath": "compactedAt",
-      "indexes": [
-        {
-          "order": "ASCENDING",
-          "queryScope": "COLLECTION"
-        },
-        {
-          "order": "DESCENDING",
-          "queryScope": "COLLECTION"
-        },
-        {
-          "order": "ASCENDING",
-          "queryScope": "COLLECTION_GROUP"
-        },
-        {
-          "order": "DESCENDING",
-          "queryScope": "COLLECTION_GROUP"
-        }
-      ]
-    },
     {
       "collectionGroup": "todoLists",
       "fieldPath": "createdAt",

Firebase/functions/src/todo/cleanup.ts

@@ -24,7 +24,6 @@ export const compactSoftDeletedTodos = onSchedule({
             while (true) {
                 let query = admin.firestore()
                     .collectionGroup("todoLists")
-                    .where("compactedAt", "==", null)
                     .where("deletedAt", "<=", admin.firestore.Timestamp.fromDate(cutoff))
                     .orderBy("deletedAt")
                     .orderBy(admin.firestore.FieldPath.documentId())
@@ -38,6 +37,9 @@ export const compactSoftDeletedTodos = onSchedule({
 
                 const batch = admin.firestore().batch();
                 snapshot.docs.forEach((document) => {
+                    if (document.data()?.compactedAt) {
+                        return;
+                    }
                     batch.update(document.ref, {
                         compactedAt: admin.firestore.FieldValue.serverTimestamp(),
                         content: admin.firestore.FieldValue.delete(),
@@ -61,7 +63,7 @@ export const compactSoftDeletedTodos = onSchedule({
                 toError(error),
                 {
                     collectionGroup: "todoLists",
-                    filter: `compactedAt == null && deletedAt <= now - ${TOMBSTONE_GRACE_PERIOD_HOURS}h`,
+                    filter: `deletedAt <= now - ${TOMBSTONE_GRACE_PERIOD_HOURS}h`,
                     orderBy: ["deletedAt", "documentId"],
                     cleanupBatchSize: CLEANUP_BATCH_SIZE
                 }