Skip to content

Commit b240e46

Browse files
committed
fix: oDomain 메서드가 다른 곳에서 resolve되지 않은 DTO와 함께 호출될 경우 잠재적 오류 발생 가능성 해결
1 parent 400cb4a commit b240e46

2 files changed

Lines changed: 4 additions & 9 deletions

File tree

DevLog/Data/Mapper/PushNotificationMapping.swift

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -13,11 +13,9 @@ extension PushNotificationResponse {
1313
case .decoded(let category):
1414
todoCategory = category
1515
case .raw(let category):
16-
guard let systemTodoCategory = SystemTodoCategory(rawValue: category) else {
17-
throw DataError.invalidData("PushNotificationResponse.todoCategory is invalid: \(category)")
18-
}
19-
20-
todoCategory = .system(systemTodoCategory)
16+
throw DataError.invalidData(
17+
"PushNotificationResponse.todoCategory must be resolved before toDomain(): \(category)"
18+
)
2119
}
2220

2321
return PushNotification(

DevLog/Data/Mapper/TodoMapping.swift

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -33,10 +33,7 @@ extension TodoResponse {
3333
case .decoded(let category):
3434
todoCategory = category
3535
case .raw(let category):
36-
guard let systemTodoCategory = SystemTodoCategory(rawValue: category) else {
37-
throw DataError.invalidData("TodoResponse.category is invalid: \(category)")
38-
}
39-
todoCategory = .system(systemTodoCategory)
36+
throw DataError.invalidData("TodoResponse.category must be resolved before toDomain(): \(category)")
4037
}
4138

4239
return Todo(

0 commit comments

Comments
 (0)