Skip to content

Commit d392f03

Browse files
committed
refactor: 불필요한 onChange(of:) 로직 제거
1 parent e6587df commit d392f03

4 files changed

Lines changed: 1 addition & 11 deletions

File tree

Application/DevLogPresentation/Sources/Home/List/TodoListFeature+Effects.swift

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,6 @@ extension TodoListFeature {
8888
func swipeTodoEffect(_ todo: TodoListItem, state: inout State) -> Effect<Action> {
8989
guard state.todos.contains(where: { $0.id == todo.id }) else { return .none }
9090
state.undoTodoId = todo.id
91-
state.deleteToastTodoId = todo.id
9291
Self.setTodoHidden(&state, todoId: todo.id, isHidden: true)
9392
return deleteEffect(todo)
9493
}

Application/DevLogPresentation/Sources/Home/List/TodoListFeature.swift

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@ struct TodoListFeature {
2727
var loading = LoadingFeature.State()
2828
var undoTodoId: String?
2929
var nextCursor: TodoCursor?
30-
var deleteToastTodoId: String?
3130
let searchResultsLimit = 5
3231

3332
init(category: TodoCategory) {
@@ -69,7 +68,6 @@ struct TodoListFeature {
6968
case swipeTodo(TodoListItem)
7069
case resetFilters
7170
case finishDeleteToast(String)
72-
case presentedDeleteToast
7371
case tapToggleCompleted(TodoListItem)
7472
case tapTogglePinned(TodoListItem)
7573
case undoDelete
@@ -207,8 +205,6 @@ private extension TodoListFeature {
207205
if state.undoTodoId == todoId {
208206
state.undoTodoId = nil
209207
}
210-
case .presentedDeleteToast:
211-
state.deleteToastTodoId = nil
212208
case .tapToggleCompleted(let todo):
213209
return toggleCompletedEffect(todo)
214210
case .tapTogglePinned(let todo):

Application/DevLogPresentation/Sources/Home/List/TodoListView.swift

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -81,11 +81,6 @@ struct TodoListView: View {
8181
.background(NavigationBarConfigurator())
8282
.background(Color(.systemGroupedBackground))
8383
.task { store.send(.onAppear) }
84-
.onChange(of: store.deleteToastTodoId) { _, todoId in
85-
guard let todoId else { return }
86-
presentDeleteTodoToast(todoId)
87-
store.send(.presentedDeleteToast)
88-
}
8984
}
9085

9186
@ViewBuilder
@@ -143,6 +138,7 @@ struct TodoListView: View {
143138
.swipeActions(edge: .trailing, allowsFullSwipe: true) {
144139
Button(role: .destructive, action: {
145140
store.send(.swipeTodo(todo))
141+
presentDeleteTodoToast(todo.id)
146142
}) {
147143
Image(systemName: "trash")
148144
}

Application/DevLogPresentation/Tests/Home/TodoListFeatureTestDoubles.swift

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -126,7 +126,6 @@ final class TodoListStoreTestAdapter {
126126

127127
func swipeTodo(_ todo: TodoListItem) async {
128128
await store.send(.swipeTodo(todo))
129-
await store.send(.presentedDeleteToast)
130129
await drainReceivedActions()
131130
}
132131

0 commit comments

Comments
 (0)